[SYCL] Do not lock unconditionally while access queue_iml::MMissedCleanupRequests #17883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
queue_impl::MMissedCleanupRequests and queue_impl::MInOrderExternalEvent are empty on hot path, check a flag instead or before the locking.
* Rename to `set`/`unset` * Simplify `read` * Be pedantic * Update comment
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
approved these changes
Apr 7, 2025
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Alexandr-Konovalov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@aelovikov-intel , that is 2nd part of check-lock-check addition. Could you please a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue_impl::MMissedCleanupRequests is empty on hot path, use a flag to avoid locking when empty.