Skip to content

Conversation

@ayylol
Copy link
Contributor

@ayylol ayylol commented Apr 7, 2025

Fixes #17516

Tests that include joint_matrix_bf16_fill_k_cache_impl.hpp may fail on windows with the following message error: no member named 'high_resolution_clock' in namespace 'std::chrono'. Including chrono resolves this.

@ayylol ayylol requested a review from a team as a code owner April 7, 2025 14:02
@ayylol ayylol temporarily deployed to WindowsCILock April 7, 2025 14:02 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 7, 2025 14:22 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock April 7, 2025 14:22 — with GitHub Actions Inactive
Copy link
Contributor

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayylol
Copy link
Contributor Author

ayylol commented Apr 7, 2025

Had a failure on unrelated test ESIMD/unified_memory_api/atomic_update_usm_dg2_pvc.cpp when running on PVC, opened #17893 regarding this. It's flaky since it passed after re-running.

@ayylol
Copy link
Contributor Author

ayylol commented Apr 8, 2025

@intel/llvm-gatekeepers this is ready to merge, thanks

@kbenzie kbenzie merged commit 5f98c48 into intel:sycl Apr 8, 2025
35 of 37 checks passed
@ayylol ayylol deleted the chrono-matrix branch April 8, 2025 13:19
KornevNikita pushed a commit that referenced this pull request May 27, 2025
Fixes #17516

Tests that include `joint_matrix_bf16_fill_k_cache_impl.hpp` may fail on
windows with the following message `error: no member named
'high_resolution_clock' in namespace 'std::chrono'`. Including chrono
resolves this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI][E2E] Some Matrix tests fail to build on windows build-e2e ci machine due to unknown member high_resolution_clock

3 participants