Skip to content

[SYCL] Change emitKernelInstrumentationData to avoid temporary std::string object creation #17895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

[SYCL] Change emitKernelInstrumentationData to avoid temporary std::string object creation #17895

merged 1 commit into from
Apr 10, 2025

Conversation

@vinser52
Copy link
Contributor

@vinser52 vinser52 commented Apr 7, 2025

Change the emitKernelInstrumentationData to accept std::string_view instead of std::string to avoid temporary std::string object creation on a hot path.

@vinser52 vinser52 requested a review from a team as a code owner April 7, 2025 20:37
@vinser52 vinser52 requested a review from uditagarwal97 April 7, 2025 20:37
@vinser52 vinser52 mentioned this pull request Apr 7, 2025
Merged
@vinser52 vinser52 requested a review from sergey-semenov April 7, 2025 20:40
@vinser52 vinser52 force-pushed the optimize_tmp_objects branch from 8760e1e to 50ee7ec Compare April 9, 2025 18:06
@vinser52 vinser52 force-pushed the optimize_tmp_objects branch from 50ee7ec to 6d51cbc Compare April 9, 2025 19:56
@vinser52 vinser52 force-pushed the optimize_tmp_objects branch from 6d51cbc to f78395a Compare April 9, 2025 20:52
@sergey-semenov sergey-semenov merged commit 0cec59e into intel:sycl Apr 10, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-semenov sergey-semenov sergey-semenov approved these changes

@uditagarwal97 uditagarwal97 Awaiting requested review from uditagarwal97 uditagarwal97 is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vinser52 @sergey-semenov