[SYCL][clang-linker-wrapper] Replace -lto-emit-asm option with -S for cuda pipeline #18000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
changed the title
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
omarahmed1111
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
ping @intel/dpcpp-tools-reviewers |
sarnex
reviewed
Apr 18, 2025
sarnex
approved these changes
Apr 18, 2025
Contributor
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
for the title can you make CLANG-LINKER-WRAPPER lowercase? thx
omarahmed1111
changed the title
Contributor
|
@intel/llvm-gatekeepers this should be ready to merge, the Jenkins/precommit failure seems to be an unrelated CI issue |
npmiller
added a commit
to npmiller/llvm
that referenced
this pull request
Apr 23, 2025
This test was fixed by: * intel#17899 * intel#18000 Fixes intel#17812
aelovikov-intel
pushed a commit
that referenced
this pull request
Apr 28, 2025
KornevNikita
pushed a commit
that referenced
this pull request
May 27, 2025
… cuda pipeline (#18000) `-lto-emit-asm` was used previously for cuda kernels pipeline when `-flto` was also used to generate ptx assembly. But after removing lto for cuda kernels, we don't need this option, instead we should use `-S` clang option to generate the ptx assembly for cuda kernels. Fixing issue [17812](#17812)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-lto-emit-asmwas used previously for cuda kernels pipeline when-fltowas also used to generate ptx assembly. But after removing lto for cuda kernels, we don't need this option, instead we should use-Sclang option to generate the ptx assembly for cuda kernels.Fixing issue 17812