Skip to content

[UR] Fix logger_validation test #18037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

[UR] Fix logger_validation test #18037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions unified-runtime/source/common/logger/ur_logger.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,21 @@ template <typename T> inline std::string toHex(T t) {
/// to be printed immediately as they occur
/// - output: stderr
inline Logger create_logger(std::string logger_name, bool skip_prefix,
bool skip_linebreak, ur_logger_level_t level) {
bool skip_linebreak,
ur_logger_level_t default_log_level) {
std::transform(logger_name.begin(), logger_name.end(), logger_name.begin(),
::toupper);
const std::string env_var_name = "UR_LOG_" + logger_name;
const auto default_flush_level = UR_LOGGER_LEVEL_ERROR;
const std::string default_output = "stderr";
auto flush_level = default_flush_level;
ur_logger_level_t level = default_log_level;
std::unique_ptr<logger::Sink> sink;

try {
auto map = getenv_to_map(env_var_name.c_str());
if (!map.has_value()) {
return Logger(level,
return Logger(default_log_level,
std::make_unique<logger::StderrSink>(
std::move(logger_name), skip_prefix, skip_linebreak));
}
Expand Down Expand Up @@ -160,7 +162,7 @@ inline Logger create_logger(std::string logger_name, bool skip_prefix,
if (!map->empty()) {
std::cerr << "Wrong logger environment variable parameter: '"
<< map->begin()->first << "'. Default logger options are set.";
return Logger(level,
return Logger(default_log_level,
std::make_unique<logger::StderrSink>(
std::move(logger_name), skip_prefix, skip_linebreak));
}
Expand All @@ -173,7 +175,7 @@ inline Logger create_logger(std::string logger_name, bool skip_prefix,
std::cerr << "Error when creating a logger instance from the '"
<< env_var_name << "' environment variable:\n"
<< e.what() << std::endl;
return Logger(level,
return Logger(default_log_level,
std::make_unique<logger::StderrSink>(
std::move(logger_name), skip_prefix, skip_linebreak));
}
Expand Down