Skip to content

[CI] Add python3-venv to build tools installation #18080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2025
Merged

[CI] Add python3-venv to build tools installation #18080

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
682b990
add venv to docker
rbanka1 Apr 17, 2025
4ad3203
opencl install
rbanka1 Apr 17, 2025
084fc53
venv
rbanka1 Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions devops/containers/ubuntu2204_build.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ RUN apt update && apt install -yqq rocm-dev && \
COPY scripts/create-sycl-user.sh /user-setup.sh
RUN /user-setup.sh

# Install venv for UR pip requirements
RUN apt update && apt install -y python3-venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this now right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted


COPY scripts/docker_entrypoint.sh /docker_entrypoint.sh

USER sycl
Expand Down
3 changes: 3 additions & 0 deletions devops/containers/ubuntu2404_intel_drivers_igc_dev.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ RUN --mount=type=secret,id=github_token \
install_driver_opt="dependencies.json dependencies-igc-dev.json --use-dev-igc"; \
GITHUB_TOKEN=$(cat /run/secrets/github_token) /install_drivers.sh $install_driver_opt --all

# Install venv for UR pip requirements
RUN apt update && apt install -y python3-venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure i understand why only this one has this, i would expect all images used for using a gpu need it, so i would expect it needs to be added to ubuntu2404_base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added there because I am using only ubuntu2404_intel_drivers:alldeps and ubuntu2204_build:latest image so venv is no needed in all of images

Copy link
Contributor

@sarnex sarnex Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file isnt doesnt contribute to ubuntu2404_intel_drivers:alldeps i think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I mixed up the files but now it is in correct place.


COPY scripts/drivers_entrypoint.sh /drivers_entrypoint.sh

USER sycl
Expand Down