Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 21, 2025

Add test to cover bfloat16 devicelib usage in dlopen/dlclose scenario.

@jinge90 jinge90 requested a review from a team as a code owner April 21, 2025 05:34
@jinge90 jinge90 requested a review from maarquitos14 April 21, 2025 05:34
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 21, 2025

Hi, @steffenlarsen and @jopperm
Could you help review this PR? This is a follow-up of #17461 to add corresponding test.

@jinge90 jinge90 requested a review from a team April 23, 2025 12:17
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 23, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit ded6f32 into intel:sycl Apr 23, 2025
25 checks passed
@uditagarwal97
Copy link
Contributor

@jinge90 Can you add a test or augment existing one to also test dlopen/dlclose with image compression enabled (--offload-compress)? The code path for handling compressed BF16 devicelibs is different so, it would be a good idea to also test that with explicit dlopen/dlclose

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 24, 2025

@jinge90 Can you add a test or augment existing one to also test dlopen/dlclose with image compression enabled (--offload-compress)? The code path for handling compressed BF16 devicelibs is different so, it would be a good idea to also test that with explicit dlopen/dlclose

Hi, @uditagarwal97
I will create a new PR to cover --offload-compress.
Thanks very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants