Skip to content

[CI][Perf] Fix sorting benchmark results files #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[CI][Perf] Fix sorting benchmark results files #18332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions devops/scripts/benchmarks/history.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,15 @@ def load(self, n: int):
benchmark_files = list(results_dir.glob("*.json"))

# Extract timestamp and sort files by it
def extract_timestamp(file_path: Path) -> str:
def extract_timestamp(file_path: Path) -> datetime:
try:
# Assumes results are stored as <name>_YYYYMMDD_HHMMSS.json
ts = file_path.stem[-len("YYYYMMDD_HHMMSS") :]
return ts if Validate.timestamp(ts) else ""
except IndexError:
return ""
if Validate.timestamp(ts):
return datetime.strptime(ts, "%Y%m%d_%H%M%S")
return datetime.fromtimestamp(0) # Default to epoch if invalid
except (IndexError, ValueError):
return datetime.fromtimestamp(0) # Default to epoch if exception

benchmark_files.sort(key=extract_timestamp, reverse=True)

Expand Down
Loading