-
Notifications
You must be signed in to change notification settings - Fork 791
[CI][Benchmarks] compute benchmarks charts naming #18558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f371f5
to
c55ff02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an idea that might simplify this patch:
move display_name() to be a benchmark metadata field. That we we never have to update old results, and we can just look it up in metadata in the scripts if needed.
c55ff02
to
32ee7f1
Compare
Thanks, made changes |
32ee7f1
to
fca7432
Compare
fca7432
to
7130ac8
Compare
7130ac8
to
1721202
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly lgtm, I like this approach better. I'm not sure what we can do with CPU Count stuff, but I really don't like fixing the metadata after the benchmarks ran.
If we can't figure out a better approach, we should try to isolate this hack better.
1721202
to
d9091a9
Compare
d9091a9
to
3d6e261
Compare
can you show a screenshot with how the new display names look like (on all types of charts)? |
awesome, thanks! |
@intel/llvm-gatekeepers please merge. The CI failure is unrelated. |
Improve readability of Historical Results chart titles, tooltips, and all charts' legends by introducing new Result object field:
display_name
for Compute Benchmarks