[Benchmarks] Speed up charts load #18728
Conversation
|
did you check that this doesn't affect x axis labels? |
PatKamin
force-pushed
the
dates-comparison
branch
from
2c73c1d to
d6083b7
Compare
Yes, the x-axis dates render properly, as before, when tested locally: |
Dates can be compared directly as strings, it works. There is no need for expensive Date object creation and comparing Date objects. Create latest runs lookup only once to reduce time complexity.
|
@intel/llvm-gatekeepers, this is ready to merge. |
|
@PatKamin - Could you please comment on the CI failures? If they are unrelated, please mention them here with the corresponding reported issues. |
|
@steffenlarsen, e2e tests jobs are related to issue #17535. IGC DEV CI Containers job has recently been removed from the list of triggered jobs for changes in benchmark files: #18732 |
|
Thank you, @PatKamin! I hope you don't mind, but I have restarted the path with the infrastructural failures. Having one or two tests that are known to fail I can live with, but I prefer to at least have the targets run the suites to feel comfortable merging changes. |
|
All green! |
3 participants
Dates can be compared directly as strings, it works. There is no need for expensive Date object creation and comparing Date objects.