-
Notifications
You must be signed in to change notification settings - Fork 791
LLVM and SPIRV-LLVM-Translator pulldown (WW22 2025) #18738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
1919 commits
Select commit
Hold shift + click to select a range
f5609aa
[flang][cuda] Use a reference for asyncObject (#140614)
clementval 2dd6a8c
[lldb-dap] Remove unused enum (NFC)
JDevlieghere f27cfea
[LLDB][Progress-On-Dap] Have indeterminate progress actually send eve…
Jlalond 91a45a3
[NFC] Pre-commit UBSAN src:*=sanitize test (#140602)
qinkunbao 2523a83
[lldb-dap] launch the adapter from the workspace folder. (#140604)
da-viper f1076da
Merge from 'main' to 'sycl-web' (221 commits)
b93bc77
[NFC] Extend ubsan-src-ignorelist-category.test
vitalybuka 5db4aea
[NFC] Extend ubsan-src-ignorelist-category.test
vitalybuka f171e05
[NFC][OpenACC] Refactor clause emission- (#140586)
erichkeane 050e49a
[RISCV] Fix copy/paste mistake in test comments. NFC
topperc dfabd61
[lldb] Support riscv32 ELF corefiles (#115408)
JDevlieghere c519190
[gn build] Port dfabd61f7370
llvmgnsyncbot b586ddf
[HLSL][NFC] Add resource globals created for metadata to test baselin…
hekota b64487d
Merge from 'sycl' to 'sycl-web' (16 commits)
fineg74 7268c4e
[NFC][MemProf] Fix typo in type name (#140500)
a53b306
[NFC][MemProf] Move Radix tree methods to their own header and cpp. (…
ad3c1d2
[NFC][MemProf] Move getGUID out of IndexedMemProfRecord (#140502)
0528848
[NFC][MemProf] Move IndexedMemProfData to its own header. (#140503)
c2fd63c
[NFC][MemProf] Add the LLVM license text and minor clean up. (#140504)
ad45031
[dsym][test][nfc] Remove DIE offsets. (#140628)
ayermolo 4cfbe55
[NFC][MemProf] Move types shared between Analysis, ProfileData and Mo…
0a71879
[gn build] Port a53b306c479c
llvmgnsyncbot 30ebcf6
[SLP][NFC]Store operand entries in the map
alexey-bataev 73c638f
[flang][cuda] Set implicit CUDA device attribute in block construct (…
clementval e9c0840
[RISCV] Add LD_RV32/SD_RV32 to RISCVInstrInfo::canFoldIntoAddrMode. (…
topperc dbfd0fd
[LangRef] Clarify that `ptrtoint` behaves like a capturing bitcast
arichardson 90daed3
[ProfileData] Restore Core as a dependency for the ProfileData librar…
07e2ba4
[AMDGPU] Set AS8 address width to 48 bits
arichardson ae46353
RISCV,LoongArch: Encode RELAX relocation implicitly
MaskRay df0358f
[lldb-dap] Remove spurious move (NFC) (#140641)
JDevlieghere a0a55df
[mlir][tensor][NFC] Code cleanup around shape inference support for `…
AaronStGeorge b8e5307
update_mir_test_checks: keep comment embedded in MIR (#140016)
ruiling 383e5f3
Revert "[Clang] Profile singly-resolved UnresolvedLookupExpr with the…
zyn0217 755acb1
[SPIR-V] Add SPV_INTEL_2d_block_io extension (#140140)
YuriPlyakhin e264cff
[NFC][AMDGPU] Update tests to use autogened CHECKs (#140648)
chinmaydd bdf03fc
Revert "[llvm][NFC] Use `llvm::sort()`" (#140668)
el-ev dba030e
[Xtensa] Rename XtensaMCAsmBackend and internalize it
MaskRay 95202ab
MC: Remove unused MCFixupKindInfo::FKF_Constant
MaskRay a754bc2
[CodeGen] Avoid repeated map lookups (NFC) (#140662)
kazutakahirata e0515c8
[clang] Fix typos in documentation (#140663)
kazutakahirata 1fa26ef
[AST] Drop const from a return type (NFC) (#140665)
kazutakahirata 575f66c
[lld] Drop const from a return type (NFC) (#140667)
kazutakahirata d561d59
[RISCV] Implement intrinsics for XAndesVPackFPH (#140007)
tclin914 5c1db38
[Clang] Functions called in discarded statements should not be instan…
cor3ntin 6181f4f
[lldb] Retcon SBValue::GetChildAtIndex(synthetic=true) (#140065)
labath 3e4c9dc
[libc++] Add explicit ABI annotations to functions from the block run…
philnik777 67f4d84
[llvm][Bazel] Adjust according to changes in 4cfbe55
akuegel 0baacd1
[flang][OpenMP] Support MLIR lowering of linear clause for omp.wsloop…
NimishMishra f8e2e70
[CGData] Return ArrayRef<std::string> in getNames (NFC) (#140675)
kazutakahirata f73287e
[libc++] Make ABI annotations explicit for windows-specific code (#14…
philnik777 d644597
[GlobalISel] Add computeNumSignBits for G_SHUFFLE_VECTOR (#139505)
davemgreen b565933
[Bazel] Adapt to d561d595c4ee741f873972c03afa829e6c566ffd
akuegel b3e15ba
[lldb] Extend information for failed connection for gdb server (#139916)
ita-sc 57aa7fa
[X86] SimplifyDemandedVectorEltsForTargetNode - replace packed fcmp n…
RKSimon 32a1b6a
[flang][veclib] Adding AMDLIBM target to fveclib (#140533)
shivaramaarao 034eaed
[lldb][DataFormatters] Adjust retrieval of unordered_map element type…
Michael137 80816e7
[mlir][LLVM] handle ArrayAttr for constant array of structs (#139724)
jeanPerier 32cf55a
[libclc] Reorganize OpenCL builtins (#140557)
frasercrmck b95ad8e
[DAGCombine] Use isLegalExtLoad for MatchLoadCombine (#140536)
davemgreen 2fb6ff4
[libclc] Fix header inclusion issues
frasercrmck d013556
[clang][bytecode] Check downcasts for the correct type (#140689)
tbaederr c9d6249
[SDAG] Ensure load is included in output chain of sincos expansion (#…
MacDue f10a905
[clang][AArch64] Move initialization of ptrauth-* function attrs (#14…
atrosinenko f5401c6
[BOLT] Gadget scanner: analyze functions without CFG information (#13…
atrosinenko 838ddc2
[CIR] Add support for indirect calls (#139748)
Lancern 4060d38
[BranchFolding] Merge debug locs on common hoisted code (#140063)
OCHyams 5dfaf84
[LLVM][AArch64] Correctly lower funnel shifts by constants. (#140058)
paulwalker-arm 0c82e06
[LICM] Use OverflowTracking to preserve NUW/NSW when reassociating. (…
fhahn 8f03e1a
[KeyInstr][Clang] Add Clang option -g[no-]key-instructions (#134627)
OCHyams a17ff7f
[X86] scalarize-fp.ll - add AVX512 test coverage
RKSimon 4b54d1a
[X86] Add #140693 test coverage
RKSimon a630309
[OpenACC] unify reduction and private-like init region recipes (#140652)
rscottmanley 746c682
[LoongArch] Introduce `32s` target feature for LA32S ISA extensions (…
heiher f62c379
[LLVM][NVPTX] Add NVPTX codegen support for clusterlaunchcontrol inst…
schwarzschild-radius 67440f0
[clang][bytecode] Diagnose comparisons of unrelated zero-sized pointe…
tbaederr 48a2836
[BOLT] Gadget scanner: detect signing oracles (#134146)
atrosinenko 3918ef3
[SLP]Fix the analysis for masked compress loads
alexey-bataev 5ed0b3a
Revert "Reduce llvm-gsymutil memory usage" (#140696)
peremyach 14706d6
[BOLT] Gadget scanner: use more appropriate types (NFC) (#135661)
atrosinenko 611aa00
Merge from 'sycl' to 'sycl-web' (3 commits)
85a6bed
[GlobalISel] Add known bits and sign-bits handling for G_SPLAT_VECTOR…
davemgreen 9c33faf
[Clang] Use correct evaluation contexts when instantiating a var with…
cor3ntin 54f2b45
[Clang][Driver][fveclib] Fix target parsing for -fveclib=AMDLIBM opti…
rohitaggarwal007 01d9c7f
[X86] combineSCALAR_TO_VECTOR - fold (v4i32 (scalar_to_vector (i32 (b…
RKSimon f057a58
[DebugInfo] Update DebugInfoFinder to take retainedNodes into account…
dzhidzhoev 9053947
[utils][TableGen] Remove unused parameter in DirectiveEmitter, NFC (#…
kparzysz 46ab684
[utils][TableGen] Unify name qualifications in DirectiveEmitter (#140…
kparzysz d56d537
[Clang] Allow vector and matrix type attributes for sub-byte _BitInt …
MrSidims cf1f116
[VPlan] Introduce constant folder in simplifyRecipe (#125365)
artagnon 4fa2c62
Fix MSVC "not all control paths return a value" warning. NFC.
RKSimon 2f66e5f
[OpenACC] Fixed error recovery during jump diagnostics for OpenACC
erichkeane 822db01
[BOLT] Fix warnings
kazutakahirata 86f2fdd
[TableGen] Tach getInputFilename to return StringRef (NFC) (#140690)
kazutakahirata ba52b56
[Analysis] Avoid repeated hash lookups (NFC) (#140691)
kazutakahirata 050892d
[Offload] Use new error code handling mechanism and lower-case messag…
RossBrunton c19a3cb
[Offload] Make OffloadAPI gtest error messages more readable (#140728)
RossBrunton ed07412
[flang] translate derived type array init to attribute if possible (#…
jeanPerier a0058d1
[SLP][NFC]Make TreeEntry a class and store "need-to-schedule" state
alexey-bataev 1a9377b
[clang][analysis] Thread Safety Analysis: Handle parenthesis (#140656)
Prabhuk 621a5a9
[X86] combineAdd - use SDPatternMatch to simplify "(add (zext (vXi1 X…
RKSimon 09fd8f0
[X86] matchBinaryPermuteShuffle - match AVX512 "cross lane" SHLDQ/SRL…
RKSimon 2318491
[SLP][NFC]Do the analysis first and then actual codegen, NFC
alexey-bataev 138a899
[OpenACC][CIR] Implement simple 'copy' lowering for combined constructs
erichkeane ad80f73
[X86] Fix a warning
kazutakahirata f786b5d
Merge from 'main' to 'sycl-web' (56 commits)
frasercrmck 95e4db8
[llvm-objdump] --adjust-vma: Call getInstruction with adjusted address
MaskRay 4a0ae4f
[RISCV] Add LD_RV32/SD_RV32 to a few more functions in RISCVInstrInfo…
topperc e8dff7b
[OpenACC] Fix location of array-section diagnostic.
erichkeane 17e293d
[LLVM][AArch64]CFINV - Add UNPREDICTABLE behaviour if CRm is not zero…
CarolineConcatto b92b548
[RISCV] Add scheduling model for SiFive P800 processors (#139316)
mshockwave 54aa928
[flang] Undo the effects of CSE for hlfir.exactly_once. (#140190)
vzakhari b3c3297
[RISCV] Fix missing WriteRes for Q extensions in SiFiveP800 scheudlin…
mshockwave 7e9d9db
[AMDGPU][True16][CodeGen] update test fmax3/fmin3 test with true16 mo…
broxigarchen ff12762
[lldb] Reduce max-children-count default to readable size (#139826)
kastiglione a1e314d
[test] Add lit.local.cfg after #140471
MaskRay d6bcae1
Merge from 'main' to 'sycl-web' (56 commits)
fineg74 f460d2d
Merge branch 'sycl-web' of https://github.com/intel/llvm into sycl-web
fineg74 6fb23af
[C] Do not diagnose unions with -Wdefault-const-init (#140725)
AaronBallman 47b89fb
[AArch64] Use i32 extract from UADDV in popcount lowering. (#140718)
davemgreen 0cf6b4f
[Docs][RISCV] Move Zilsd to 'Supported' status. NFC (#140757)
topperc 2a1af50
[DirectX] scalarize the dx.isinf intrinsic (#140638)
spall 5999988
[HLSL] Move where ZExt happens in 'EmitStoreThroughExtVectorComponent…
spall 747620d
[mlir] [XeGPU] Add XeGPU workgroup to subgroup pass (#139477)
nbpatel 51e222e
[BOLT][AArch64] Fix crash for conditional tail calls (#140669)
maksfb 0931874
[Coverage] Add testing to validate code coverage for exceptions (#133…
justincady cbcfe66
[CIR] Upstream support for iterator-based range for loops (#140636)
andykaylor a9ee8e4
Create a EncodingConverter class with both iconv and icu support. (#1…
abhina-sree c17ae16
[flang][cuda] Use nullptr for comparison (#140767)
clementval 9440610
[libclc] Reduce OpenCL builtins diff with upstream (#18574)
frasercrmck 38250ed
[gn build] Manually port a9ee8e4a
aeubanks 611f47c
[flang] Fix a warning
kazutakahirata b99e575
Revert "[mlir] [XeGPU] Add XeGPU workgroup to subgroup pass (#139477)…
jplehr 4964d98
[compiler-rt] Replace deprecated os_trace calls on mac (#138908)
DanBlackwell 0ccd57e
[RISCV] Add basic coverage of vector.partial.reduce.add [nfc]
preames c555c8d
[C] Do not diagnose flexible array members with -Wdefault-const-init-…
AaronBallman 9260d31
[clang][bytecode][NFC] Remove Frame.cpp (#140750)
tbaederr 8708c42
[RISCV] Add zvqdotq tests using partial.reduce.add [nfc]
preames be5b4fa
Update InterpreterProperties.td (#140746)
anthonycabreralara 1b6b036
[lldb][docs] add command to save core file in gdb to lldb command map…
da-viper 705e27c
[LoopPeel] Add tests for peeling from end with variable trip counts.
fhahn 26d9cb1
[MC][DebugInfo] Emit linetable entries with known offsets immediately…
jmorse 5aa3171
AMDGPU: Add regression test for multiple frame index lowering (#140784)
arsenm 3f196e0
[lldb][core] Fix getting summary of a variable pointing to r/o memory…
igorkudrin 317c932
Suppress errors from well-formed-testing type traits in SFINAE contex…
aaronpuchert 11db128
[gn build] Manually port 8f03e1a
aeubanks 04ad8d4
Emit inbounds and nuw attributes in memref. (#138984)
lpy cbac2a9
[llvm] Use llvm::is_contained (NFC) (#140742)
kazutakahirata e25abd0
[bugpoint] Use a range-based for loop (NFC) (#140743)
kazutakahirata 98595cf
[llvm] prepare explicit template instantiations in llvm/CodeGen for D…
andrurogerz a690852
[llvm-exegesis] Error instead of aborting on verification failure (#1…
boomanaiden154 a414877
[x64][win] Add compiler support for x64 import call optimization (equ…
dpaoliello de3e8ff
[NFC][CI] Reformat python files
boomanaiden154 c39915f
[mlir][NFC] Simplify constant checks with isOneInteger and renamed is…
hanhanW d299242
[Attributor] Don't replace `addrspacecast (ptr null to ptr addrspace(…
shiltian 554e27e
[CIR][NFC] Eliminate ArgInfo structure (#140612)
andykaylor dfc65ef
[lldb][lldb-dap] show modules pane if supported by the adapter (#140603)
da-viper 6cac792
[mlir][Vector] Improve `vector.mask` verifier (#139823)
dcaballe 580f70e
[mlir] Check for int limits when converting gpu dims (#140747)
Max191 6b9da28
[AMDGPU][LowerBufferFatPointers] Handle addrspacecast null to p7 (#14…
krzysz00 13c467b
[AMDGPU] Add make.buffer.rsrc to InferAddressSpaces (#140770)
krzysz00 f78a081
[gn] port d561d595c4ee (clang riscv_andes_vector.td)
nico 08b21c8
[gn] fix mistake in f78a081cdb3
nico d549abf
[gn build] Port 9260d310f1cb
llvmgnsyncbot da62b3e
[gn build] Port a9ee8e4a454e
llvmgnsyncbot 88c4ef2
[gn build] Port d561d595c4ee
llvmgnsyncbot 80f0ffb
[lld][WebAssembly] Set the target-cpu in LTO config (#140010)
yamt 744a469
[BOLT,test] Add --image-base to tests that use --section-start
MaskRay ada2fbf
[GISel] Fix ShuffleVector assert (#139769)
lialan 7385772
[mlir] [liveness] Conservatively mark operands of return-like op insi…
nhat-nguyen 3cf6565
[LoongArch] Remove wrong vector shuffle lowering for lasx. (#140688)
tangaac 7b51339
[lldb-dap] Avoid double 'new' events for dyld on Darwin (#140810)
JDevlieghere 6811a3b
[flang][cuda] Allocate extra descriptor in managed memory when it is …
clementval 0649122
[bazel][mlir] Add missing dep for 747620d (#140830)
patdoyle-google 701fe51
[Clang] Fix an inadvertent overwrite of sub-initializers (#140714)
zyn0217 0dfdf7e
[clang-format] Handle raw string literals containing JSON code (#140666)
owenca 57a90ed
[OpenMP][GPU][FIX] Enable generic barriers in single threaded context…
jdoerfert 0f2a469
Revert "[AMDGPU] remove move instruction if there is no user of it (#…
shiltian 9a553d3
[MLIR][NVVM] Add NVVMRequiresSM op traits (#126886)
Wolfram70 211ee04
[llvm-debuginfo-analyzer] Fix a couple of unhandled DWARF situations …
jalopezg-git a4782ff
[llvm-mca] Drop const from a return type (NFC) (#140836)
kazutakahirata adbe155
[polly] Drop const from return types (NFC) (#140837)
kazutakahirata 51b288d
[CodeGen] Avoid repeated hash lookups (NFC) (#140838)
kazutakahirata 557448e
[DebugInfo] Use std::map::try_emplace (NFC) (#140839)
kazutakahirata 1fd2436
[CodeGen] Use range-based for loops (NFC) (#140840)
kazutakahirata 9d0614e
[lldb-dap] fix disassembly request instruction offset handling (#140486)
eronnen 3c8a6bc
[clang][bytecode] Optimize classify() further (#140735)
tbaederr 645846d
[clang][bytecode] Initialize global strings via memcpy (#140789)
tbaederr 2ed8c27
add @skipIfWindows to unresolved disassemble test on windows (#140852)
eronnen d50c85d
[analyzer][NFC] Move PrettyStackTraceLocationContext into dispatchWor…
balazs-benics-sonarsource f87bcf1
[LoongArch] Add patterns for vstelm instructions (#139201)
tangaac a21986b
[MLIR][PDL] Skip over all results in the PDL Bytecode if a Constraint…
jorickert 49a9bbb
[Bazel] Port a9ee8e4a454ec01fefba8829d2847527aa80623f
akuegel bc546ca
[clang][NFC] Clean up ASTContext.cpp (#140847)
tbaederr 9f1da90
[mlir][SPIRV] Do not rewrite CompositeInsert for coopmatrix (#137837)
Hsiangkai 5bd3c44
[clang-tools-extra] Remove redundant control flow statements (NFC) (#…
kazutakahirata 462cede
[Bazel] Follow fixes for 9a553d3766aacb69e884823da92dedff264e3f0f
akuegel ad05543
[Bazel] Also adapt test/BUILD for 9a553d3766aacb69e884823da92dedff264…
akuegel fe6290e
[llvm] Use *Map::try_emplace (NFC) (#140843)
kazutakahirata 9f4cea2
[llvm] Fix typos in documentation (#140844)
kazutakahirata f4cebe5
[Clang] Fix a regression introduced by #140576 (#140859)
cor3ntin d827588
[VectorCombine] Scalarize binop-like intrinsics (#138095)
lukel97 dec214d
[X86] combineINSERT_SUBVECTOR - generalise insert_subvector(x,extract…
RKSimon 64dcf78
[clang-tidy][NFC] Refactor `modernize-pass-by-value` check code and t…
vbvictor 5b5c57d
Add llvm-project archive issues for Chromium bug tracker (#132030)
smithp35 67489c7
[mlir] Silence an unused variable warnings in builds without asserts.
akuegel e70568e
[libclc] Re-use shuffle_decl.inc in OpenCL shuffle2 declaration (#140…
wenju-he 6553dc3
[NVPTX] Support the OpenCL generic addrspace feature by default (#137…
frasercrmck 1b69f77
[MLIR][Doc] Add documentation for OpAsmAttr/TypeInterface (#140244)
ZenithalHourlyRate 22a4930
[mlir][tosa] Allow creation of reshape with unranked output (#140617)
lhutton1 1a08aa2
[AArch64] Split AArch64ISD::COND_SMSTART/STOP off AArch64::SMSTART/ST…
MacDue 80913b4
[libclc][NFC] Reuse inc file for OpenCL frexp decl
frasercrmck f054aa2
[flang][OpenMP] fix diagnostic for bad cancel type (#140798)
tblah 7a8090c
[AArch64] Remove unused ISD nodes (NFC) (#140706)
MacDue 478a978
Merge from 'sycl' to 'sycl-web' (18 commits)
a7081e5
Merge from 'main' to 'sycl-web' (144 commits)
mikolaj-pirog 825ef67
Merge from 'sycl' to 'sycl-web' (5 commits)
mikolaj-pirog 071edb1
Merge from 'sycl' to 'sycl-web' (2 commits)
6ebc051
Merge commit '7a8090c037255b54895d61df2eb141fee48d6d83' into llvmspir…
jsji ab8cc8b
Fix build after LLVM InlineAsm changes (#3155)
svenvh c7e3dd4
Make OCLUtil.h compatible with C++20 standard (#3149)
jaladreips 56df2ad
Use native for the system separator for source path string (#3157)
MrSidims 6495e45
Deprecate SPV_INTEL_hw_thread_queries extension from forward llvm-spi…
MrSidims 5e333db
Add actions job to create backports (#3156)
MrSidims 417c39b
Pick SHA of commit to cherry-pick from merge commit (#3167)
MrSidims 8c0becb
Fix typos in the backport script (#3168)
MrSidims 258376e
Add post-commit job to cleanup backport branches (#3176)
MrSidims 9a74f8d
Add listener for other workflows to trigger them on a backport (#3177)
MrSidims 875605f
Add SPV_INTEL_int4 extension (#3178)
MrSidims a8ea3b2
Add missing SPV_INTEL_fp_fast_math_mode (#3139)
pvelesko 92a8bb1
Fix typo in cleanup backports script (#3181)
MrSidims a3123dc
Fix several failing tests (#29354)
fineg74 ef73d84
Add back removed customization (#29550)
jsji 1507f32
[libspirv] Align __clc_sincos with upstream (#18615)
frasercrmck d3cfdea
[libclc] Align generic AS support with upstream (#18617)
frasercrmck b5bc447
[libclc] Reduce diff with upstream in CLC headers (#18625)
frasercrmck 571750f
[libclc] Revert downstream changes to OpenCL builtins (#18634)
frasercrmck 209e0b3
[libclc] Delete duplicate generic vstore impl (#18635)
frasercrmck 616fadc
[libspirv] Make OpenCL not depend on SPIR-V (#18659)
frasercrmck 90af614
[libclc] Fix conflict resolution; delete unused file (#18685)
frasercrmck f56b784
Merge remote-tracking branch 'origin/sycl' into llvmspirv_pulldown
jsji 94df314
[SYCL] Don't set alwaysinline for NativeCPU (#29546)
jsji 30064ec
[NFC] Update intel-fpga-local.cpp after 61b435ec4de6b
jsji 2133dc5
[Clang] Fix conflict resolution in SemaDeclAttr
jsji 7303f8e
[libclc] Support the generic address space (#137183)
frasercrmck cb4c187
[libclc] Move all remquo address spaces to CLC library (#140871)
frasercrmck 0fce02b
Revert "Deprecate SPV_INTEL_hw_thread_queries extension from forward …
jsji 94f46ae
[SYCL][E2E] Disable NEO Cache for shaderdump check
jsji 2736632
Merge remote-tracking branch 'origin/sycl' into llvmspirv_pulldown
frasercrmck 1631cf7
[SYCL] Also disable alwasyinline for SYCL device
jsji cdf4060
Merge remote-tracking branch 'origin/sycl' into llvmspirv_pulldown
jsji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also add
!LangOpts.SYCLIsDevice
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can.