Skip to content

[SYCL] Handle non-type template parameters in integration headers #18914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

[SYCL] Handle non-type template parameters in integration headers #18914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ba0a1f
[SYCL] Handle non-type template parameters in integration headers
premanandrao Jun 11, 2025
4916cac
Fix clang-format
premanandrao Jun 11, 2025
48fe740
clang-format again
premanandrao Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions clang/lib/AST/StmtPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,9 @@ void StmtPrinter::VisitDeclRefExpr(DeclRefExpr *Node) {
if (Node->hasTemplateKeyword())
OS << "template ";

bool ForceAnonymous =
Policy.PrintAsCanonical && VD->getKind() == Decl::NonTypeTemplateParm;
bool ForceAnonymous = Policy.PrintAsCanonical &&
!Policy.SkipCanonicalizationOfTemplateTypeParms &&
VD->getKind() == Decl::NonTypeTemplateParm;
DeclarationNameInfo NameInfo = Node->getNameInfo();
if (IdentifierInfo *ID = NameInfo.getName().getAsIdentifierInfo();
!ForceAnonymous &&
Expand Down
13 changes: 11 additions & 2 deletions clang/test/CodeGenSYCL/int_header_nttp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
// CHECK: Forward declarations of templated kernel function types:
// CHECK-NEXT: template <typename T, T nttp> struct SelfReferentialNTTP;
// CHECK-NEXT: template <typename U, int nttp> struct NonSelfRef;
// CHECK-NEXT: template <int N> struct alignas(N) OpaqueType;

template<typename T, T nttp>
struct SelfReferentialNTTP {};
Expand All @@ -17,7 +18,15 @@ using Foo = int;
template<typename U, Foo nttp>
struct NonSelfRef {};

template <int N> struct alignas(N) OpaqueType {
char data[N];
};
template <typename T> class Kernel;

void foo() {
sycl::kernel_single_task<SelfReferentialNTTP<int, 1>>([](){});
sycl::kernel_single_task<NonSelfRef<int, 1>>([](){});
auto Lambda = [](){};
sycl::kernel_single_task<SelfReferentialNTTP<int, 1>>(Lambda);
sycl::kernel_single_task<NonSelfRef<int, 1>>(Lambda);
using scalar_t = OpaqueType<sizeof(int)>;
sycl::kernel_single_task<class Kernel<scalar_t>>(Lambda);
}