Skip to content

[SYCL][SPIRV] Use upstream declaration of builtins #19199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][SPIRV] Use upstream declaration of builtins #19199

wants to merge 4 commits into from

Conversation

Naghasan
Copy link
Contributor

Upstream started to use SPIR-V builtins and rather than pushing for the adoption of our Sema hacks (with the limitations), we now started to provide them as part of a specific headers.

The patch removes GenericCastToPtrExplicit from the SPIRVBuiltins.td and use __clang_spirv_builtins.h instead.

@Naghasan
[SYCL][SPIRV] Use upstream declaration of builtins
c7b21f8 
Upstream started to use SPIR-V builtins and rather than pushing for
the adoption of our Sema hacks (with the limitations),
we now started to provide them as part of a specific headers.

The patch removes GenericCastToPtrExplicit from the SPIRVBuiltins.td
and use __clang_spirv_builtins.h instead.
@Naghasan Naghasan marked this pull request as ready for review July 15, 2025 12:52
@Naghasan Naghasan requested review from a team as code owners July 15, 2025 12:52
@Naghasan Naghasan requested a review from maarquitos14 July 15, 2025 12:52
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

@intel/llvm-gatekeepers please consider merging

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@intel/llvm-gatekeepers please consider merging

@KornevNikita
Copy link
Contributor

@Naghasan hi, could you please update the branch and therefore re-trigger the pre-commit?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

@intel/llvm-gatekeepers please consider merging

8 similar comments
@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

@intel/llvm-gatekeepers please consider merging

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

@github-actions GitHub Actions
Copy link
Contributor

@intel/llvm-gatekeepers please consider merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maarquitos14 maarquitos14 maarquitos14 approved these changes

@Fznamznon Fznamznon Fznamznon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Naghasan @KornevNikita @maarquitos14 @Fznamznon @steffenlarsen