[UR][Offload] Event waiting #19594
[UR][Offload] Event waiting #19594
Conversation
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue functions.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // Create events on each active queue for an arbitrary thread to block on | ||
| // TODO: Can we efficiently check if each thread is "finished" rather than | ||
| // creating an event? |
There was a problem hiding this comment.
stream_queue_t::syncEvents has some optimizations to only sync streams that need to be
There was a problem hiding this comment.
stream_queue_t::syncEvents doesn't seem to exist. stream_queue_t::syncStreams does, but doesn't seem to exclude completed threads as far as I can tell.
There was a problem hiding this comment.
llvm/llvm-project#152304 Should make waiting on an empty queue basically a no-op.
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@pbalcer @callumfare I think I've resolved all the concerns with this, can I get another look? |
|
@intel/llvm-gatekeepers Please merge. @callumfare When you're back, we can look at improving performance if required; I think there is discussion to have, but they probably make sense as part of another task and also possibly with liboffload changes. |
Implement urEventsWait[WithBarrier] and respect the waitlist of enqueue
functions.