-
Notifications
You must be signed in to change notification settings - Fork 791
LLVM and SPIRV-LLVM-Translator pulldown (WW31 2025) #19622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
1737 commits
Select commit
Hold shift + click to select a range
a0e8462
[compiler-rt][sanitizer_common] Improve handling of env vars for iOS …
DanBlackwell d66254e
Revert " Move python binding tests to lit framework (#146844)" (#146931)
DeinAlptraum 994501a
[Clang] Fix evaluation context of lambdas appearing in discarded stat…
cor3ntin 1e76f01
Fix the build after 8ac7210b7f0ad49ae7809bf6a9faf2f7433384b0 made TTI…
d0k 378f248
[lldb] Add SB API to make a breakpoint a hardware breakpoint (#146602)
JDevlieghere bfd4575
Revert "[AMDGPU] SelectionDAG divergence tracking should take into ac…
fhahn a3dea0a
[gn build] Port 795b17d0b821
llvmgnsyncbot 48ef55c
[CGP] Update tests to use autogen scripts, and refresh check lines
preames 0afbf17
[LAA,LV] Add tests with early-exit loops and deref assumptions.
fhahn ea88634
[Support] Remove an unnecessary cast (NFC) (#146810)
kazutakahirata be762b7
[RISCV] Efficiently lower (select cond, u, rot[r/l](u, rot.amt)) usin…
bababuck 08ed9e1
[LV] Add tests for narrowing interleave groups with single scalar ops.
fhahn 67d6679
[flang][prescanner] fix invalid check (#146613)
akuhlens bc89380
[flang][preprocessor] fix use of bitwise-and for logical-and (#146758)
akuhlens 6efa3df
[VPlan] Handle interleave groups with trivially narrow operands.
fhahn e18c5de
[X86/AArch64] Autogen two additional tests
preames ec35065
[ARM] Add neon vector support for rint
davemgreen e35cf02
[RISCV] Pass RISCVSubtarget to translateSetCCForBranch. NFC
topperc d0d84c4
[RISCV] Add SF_ to SiFive instructions in RISCVGenInstrInfo.inc. NFC …
topperc 3c13257
[RISCV] Rename XTHeadVdot instructions to match their mnemonic. NFC (…
topperc 2aa0f0a
[AArch64] Add option -msve-streaming-vector-bits= . (#144611)
efriedma-quic 1995fd9
[lldb] Extract DW_OP_deref evaluation code (NFC) (#146801)
JDevlieghere eda3161
AMDGPU: Implement tensor load and store instructions for gfx1250 (#14…
changpeng 17cb0a7
[lldb][docs] Fix another broken markdown link
JDevlieghere 0b98b27
Use the root directory as the SDK root on POSIX platforms
CodingCarpincho dd3214d
[flang] Fix handling of identifier in column 1 of free form continuat…
klausler 2b7e3f6
[flang] Unify derived types in distinct module files (#146759)
klausler 1725cc0
[lldb] Remove unused `hardware` argument (NFC)
JDevlieghere 0ceb0c3
[NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined…
inbelic 1f7effc
[mlir][acc][flang] Use SymbolRefAttr for func_name in ACC routine (#1…
delaram-talaashrafi 45083dc
[lldb][framework] Correctly place framework files in framework with s…
chelcassanova 9bfb347
[lldb][RPC] Upstream lldb-rpc-gen tool (#138031)
chelcassanova 2910c24
[Modules] Record side effect info in EvaluatedStmt (#146468)
hnrklssn 96f7f22
[mlir][examples] Use {} instead of std::nullopt (NFC) (#146949)
kazutakahirata 0a02c28
[clang-doc] add namespace references to VarInfo (#146964)
evelez7 7e04bfb
Revert "[lldb][RPC] Upstream lldb-rpc-gen tool" (#146969)
chelcassanova ba9c262
[mlir] Use llvm::any_of and llvm::all_of (NFC) (#146947)
kazutakahirata c3947a6
[AMDGPU][NFC] Remove a redundant test (#146888)
paperchalice 60d1c4e
[llvm] Use range-based for loops (NFC) (#146945)
kazutakahirata 0db0c79
[mlir] Use range-based for loops (NFC) (#146946)
kazutakahirata 965b944
[TableGen] Use emplace_back and const correct two reference arguments…
topperc db03c27
[AMDGPU] Re-apply: Implement vop3p complex pattern optmization for gi…
Shoreshen 48e89a8
[mlir][transform] Fix Wtype-limits warning (#146898)
CoTinker 5b8304d
Revert "[AMDGPU] Re-apply: Implement vop3p complex pattern optmizatio…
Shoreshen 61529d9
[RISCV] Remove implied extension Zvfhmin for XAndesVPackFPH (#146861)
tclin914 724dfdc
[OpenCL] Add declarations for version 1.1 of cl_intel_subgroups_short…
Maetveis ddcccc4
[OpenCL] Add decls for cl_intel_subgroups_char, cl_intel_subgroups_lo…
Maetveis 8c9e0c6
[flang][OpenMP] Allocate `reduction` init temps on the stack for GPUs…
ergawy 85aaaf6
[clang-tidy] EndSourceFile() for preprocessor before diagnostic clien…
dbartol afd20aa
[clang-scan-deps] Fix "unterminated conditional directive" bug (#146645)
ziqingluo-90 8fe205d
[Serialization] Remove an unnecessary cast (NFC) (#146986)
kazutakahirata 0612c4b
[Driver][Test] pgo-sample-use-profi.c: Specify targets to fix test (#…
nilanjana87 872eac7
[RISCV] Move vendor clang intrinsics tests to seperate directory. NFC…
tclin914 a550fef
[llvm] Use llvm::fill instead of std::fill(NFC) (#146911)
Zhenhang1213 671870b
[RISCV] Fold funct7 into class for XAndesVBFHCvt instructions. NFC.
tclin914 f724d31
[RISCV] Trim line to 80 chars in RISCVInstrInfoXAndes.td. NFC.
tclin914 59e812f
[lldb][test] Skip pointer to std::unordered_map formatter tests on ol…
Michael137 5a9e6ba
[clang-tidy] fix false negatives with type aliases in `cppcoreguidlin…
vbvictor 06c988c
[RISCV][VLOPT] Add support for vwsll.vx/vv. (#146998)
topperc 25bf90e
[MLIR][Docs] Fix typo in addTypeAttributeConversion comment (#146977)
xl4624 1d5d125
[ConstantFolding] Consolidate poison propagation for intrinsics (#146…
nikic 3e78aff
[flang] Fix Windows bot failure caused by #146667 (#147002)
ergawy d84df61
[flang] Fix x86 REQUIRES in a couple of tests (#146869)
DavidSpickett 7ee2c72
[AArch64] Mark aarch64_set_fpmr as IntrWriteMem (#146353)
CarolineConcatto 7e3e2e1
MCParser: Add SMLoc to expressions
MaskRay 6181a06
[NFC][LoopFuse] Regenerate LoopFusion tests using UTC (#146902)
madhur13490 25f05c0
[llvm][release] On release page, explain package types and verificati…
DavidSpickett a89e232
[lldb][DataFormatter] Format libstdc++ unique_ptr like we do libc++ (…
Michael137 c7d3b81
[bazel] Port 0ceb0c377a3e67b70965c32e7f21fe8b33f555d2
d0k d74c9ef
[lldb][test] Skip TestFrameVarDILGlobalVariableLookup.py on older AAr…
Michael137 2fcf1f8
[MsDemangle] Use LLVM style RTTI for AST nodes (#143410)
Nerixyz de3c841
[debuginfo][coro] Emit debug info labels for coroutine resume points …
vogelsgesang a34b175
[DLCov] Origin-Tracking: Add debugify support (#143594)
SLTozer a774463
[libc++][NFC] Fixed some wrongly spelled `_LIBCPP_STD_VER` in comment…
H-G-Hristov 8f6a964
[libc++] Fix tests broken on the Buildkite CI (#146733)
ldionne 1f8e2a4
[libc++][NFC] Remove __remove_uncvref (#140531)
philnik777 81e6552
[libclc] Make library output directories explicit (#146833)
frasercrmck be63b23
[OpenCL] Add decls for cl_intel_subgroup_local_block_io (#146656)
Maetveis 222e795
[libclc] Fix target dependency
frasercrmck 0437895
[X86] combineShiftToPMULH - convert matching to use SDPatternMatch. NFC.
RKSimon 03cfba4
[MLIR][IRDL][CMake] CMake fixes for cross-compilation (#145672)
arthurqiu 3099b7e
[Passes] Move LoopInterchange into optimization pipeline (#145503)
kasuga-fj ea5ee2e
[mlir][OpenMP] Don't allow firstprivate for simd (#146734)
tblah ec752c6
[LoongArch] Pre-commit tests for optimizing insert bitcast fp element
zhaoqi5 d0db199
[PowerPC] anyext_srl.ll - regenerate checks
RKSimon 4a6d78e
[MLIR][ODS] Improve diagnostic for using a property as an anchor
joker-eph d17a248
[libcxx][test] Correct syntax of lit directives in some tests (#146886)
DavidSpickett 0ba5958
[flang] Optimize assignments of multidimensional arrays (#146408)
luporl 274e798
[flang] use set_union instead of merge in added DerivedTypeCache (#14…
jeanPerier b9b2661
[MLIR][Dialect] Add XeVM dialect (#144811)
silee2 ad20dc0
[mlir][Transforms] Add `ApplyConversionAction` for profiling purposes…
matthias-springer af2bb8f
[Clang] Correctly handle allocations in the condition of a `if conste…
cor3ntin 0b4941a
[mlir][xevm] Add missing static value utils dependency (#147051)
adam-smnk 5eb195f
[mlir][Vector] Fold vector.constant_mask to SplatElementsAttr (#146724)
Groverkss ed17bf1
[flang] Fix tests broken by #146734 (#147055)
tblah 740da00
[DAG] Fix static analyzer warning about mismatched argument comments …
RKSimon 79d5db4
[NFC][CodeGen] Improve comments in Target.td (#147006)
jurahul e5cd9bd
[NFC][TableGen] Delete extra spaces in comments (#147004)
jurahul 45909ec
[PowePC] using MTVSRBMI instruction instead of constant pool in power…
diggerlin 258c048
[clang][bytecode] Fix copy constructors for empty unions (#147050)
tbaederr 9fcea2e
[ARM] Add neon vector support for roundeven
davemgreen 32946eb
[lldb][Formatters] Fix weak reference count for std::shared_ptr/std::…
Michael137 5224a17
[FuzzMutate] Prevent the mutator from generating illegal memory opera…
mgcarrasco f46c1d6
[PowerPC] Fix a warning
kazutakahirata a465e35
[Sema] Remove an unnecessary cast (NFC) (#146985)
kazutakahirata 60fca53
[llvm] Use llvm::fill (NFC) (#146988)
kazutakahirata e854321
[IR] Use llvm::for_each (NFC) (#146989)
kazutakahirata a438c60
[X86][FP16] Do not customize WidenLowerNode for half if VLX not enabl…
phoebewang 56e3fc4
[NFC][HLSL][RootSignature] Split up `HLSLRootSignatureUtils` (#146124)
inbelic a178949
[gn build] Port 56e3fc4c42d1
llvmgnsyncbot a4f31cc
[mlir-tblgen] Emit named operand indices (#146839)
Meinersbur 0008af8
[SROA] Allow as zext<i1> index when unfolding GEP select (#146929)
AlexMaclean 6b19cdc
[Offload][amdgpu] Map `INVALID_CODE_OBJECT` to `INVALID_BINARY` (#147…
RossBrunton fd5ed04
[Flang][OpenMP][NFC] Remove flag toggling deprecated no hlfir flow in…
agozillon 2472cdc
[InstCombine] Refine nuw propagation in `OptimizePointerDifference` (…
dtcxzyw cc6a864
[RISCV][VLOPT] Add support for vfrec7.v (#146918)
mikhailramalho b0473c5
[InstCombine] Pull extract through broadcast (#143380)
agorenstein-nvidia 6a94814
[HLSL][RootSignature] Update `setDefaultFlags` to account for Root Si…
inbelic 06922c4
[PowerPC] Pre-commit test case to ensure that milicode is not used fo…
diggerlin 7b517cf
MCParser: Add SMLoc to expressions
MaskRay b38de6c
[NFCI][LLVM] Adopt `ArrayRef::consume_front()` in a few places (#146793)
jurahul 249acb8
MC: Update tests that check column information
MaskRay 8740ff8
[mlir][docs][python] Fix up testing docs (#147092)
kuhar 833839b
[ASTMatchers][NFC] improve 'isInteger' docs to show matching of unsig…
vbvictor 777391a
MCFixup: Improve location accuracy and remove MCFixup::Loc
MaskRay 20b3ab5
MCFixup: Remove unused Loc argument
MaskRay 372752c
MCFixup: Remove unused Loc argument
MaskRay e2510b1
[clang] SourceManager: Cache offsets for LastFileIDLookup to speed up…
hokein 1be685a
[mlir] Remove unnecessary casts (NFC) (#147097)
kazutakahirata ed0ee3a
[mlir] Use llvm::fill (NFC) (#147100)
kazutakahirata fa9adbf
[mlir] Remove unused includes (NFC) (#147101)
kazutakahirata ea60057
MCFixup: Add PCRel to ctor parameter and set it in X86MCCodeEmitter
MaskRay 1f3f987
[VPlan] Fix crash when narrowing interleave-groups with reuse.
fhahn 454e4e3
[mlir][AffineExpr] Order arguments in the commutative affine exprs (#…
Hardcode84 6db02dc
[Clang] Introduce `--offload-targets` for `-fopenmp-targets` (#146594)
jhuber6 07286b1
[InstCombine] Propagate poison pow[i], [us]add, [us]sub and [us]mul (…
badumbatish 07ae19c
[RISCV] Move performCombineVMergeAndVOps to RISCVVectorPeephole (#144…
lukel97 eb84af4
AArch64MCCodeEmitter: Set PCRel at fixup creation
MaskRay d337e09
SystemZMCCodeEmitter: Set PCRel at fixup creation
MaskRay 83fbd86
SPARCMCCodeEmitter: Set PCRel at fixup creation
MaskRay 7d500b1
SPARC: Remove unneeded MCFixupKindInfo::FKF_IsPCRel
MaskRay b9257a3
RISCVMCCodeEmitter: Set PCRel at fixup creation
MaskRay 43397e5
LoongArchMCCodeEmitter: Set PCRel at fixup creation
MaskRay 955c048
AArch64MCCodeEmitter: Standardize how fixups are appended
MaskRay 2bfc488
X86MCCodeEmitter: Remove unneeded MCFixupKindInfo::FKF_IsPCRel
MaskRay 73c03b9
XtensaMCCodeEmitter: Set PCRel at fixup creation
MaskRay 6670fe2
ARMMCCodeEmitter: Set PCRel at fixup creation
MaskRay 8bb4e53
PPCMCCodeEmitter: Set PCRel at fixup creation
MaskRay 637a382
SystemZMCCodeEmitter: Remove unneeded MCFixupKindInfo::FKF_IsPCRel
MaskRay 3c5d03a
SystemZMCCodeEmitter: Standardize how fixups are appended
MaskRay 5b7f1c1
BOLT: Replace deprecated MCFixupKindInfo::FKF_IsPCRel with MCFixup::i…
MaskRay def731a
MipsMCCodeEmitter: Set PCRel at fixup creation
MaskRay 56cf2cb
HexagonMCCodeEmitter: Set PCRel at fixup creation
MaskRay 21cf7bd
BPFMCCodeEmitter: Set PCRel at fixup creation
MaskRay b418e73
AMDGPUMCCodeEmitter: Set PCRel at fixup creation
MaskRay 3544eba
MSP430MCCodeEmitter: Set PCRel at fixup creation
MaskRay 7b7dc15
AVRMCCodeEmitter: Set PCRel at fixup creation
MaskRay 755b473
VEMCCodeEmitter: Set PCRel at fixup creation
MaskRay add2c58
[Index] Remove an unnecessary cast (NFC) (#146944)
kazutakahirata 21fb7e6
[Driver] Use range-based for loops (NFC) (#146987)
kazutakahirata 57cb926
[Analysis] Drop const from a return type (NFC) (#147098)
kazutakahirata f78d74f
[llvm] Use llvm::fill (NFC) (#147099)
kazutakahirata 3e2e99b
[Analysis] Remove traces of BlockEdgesAdder (#147102)
kazutakahirata 0937233
X86: Test fixup/relocation with -filetype=obj
MaskRay 0e9571d
M68kMCCodeEmitter: Standardize how fixups are appended
MaskRay d85536c
CSKYMCCodeEmitter: Set PCRel at fixup creation
MaskRay 74fcff4
CSKY: Remove unneeded MCFixupKindInfo::FKF_IsPCRel
MaskRay 6ec27f1
MCFixup: Remove FKF_IsPCRel
MaskRay 45509a8
M68,test: Remove CHECK lines for MCAsmStreamer's fixup output
MaskRay 5760c06
M68,test: Remove CHECK lines for MCAsmStreamer's fixup output
MaskRay c05593b
M68: Replace FK_PCRel_ with FK_Data_+PCRel
MaskRay ae3d313
VE: Remove dead FK_PCRel_* code
MaskRay 22c590b
[RISCV][ISel] Optimize setcc with mask test idioms (#147015)
dtcxzyw c203791
X86: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag
MaskRay 66952f7
M68k: Remove unused deprecated FK_PCRel_
MaskRay a26f8f2
BPF: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag
MaskRay 970ed59
CSKY: Remove unused deprecated FK_PCRel_4
MaskRay abaa55d
COFF: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag
MaskRay 49c91ec
Hexagon: Remove dead deprecated FK_PCRel_4 use
MaskRay 158fa4a
AMDGPU: Replace deprecated FK_PCRel_ with FK_Data_ fixup and PCRel flag
MaskRay 32f83d3
MCFixup: Remove FK_PCRel_
MaskRay 9372f40
[LoongArch] Pre-commit for optimizing bitcast extracted fp elements. NFC
zhaoqi5 3d6f4fb
[Clang][Sema] Do not perform error recovery for invalid member using-…
zwuis 65e11f6
[Clang][AArch64] Remove redundant tune args to the backend (#146896)
tomershafir a49a5db
test: Update mc-dump.s
MaskRay cd39eae
MC: Merge MCFixupKindInfo.h into MCAsmBackend.h
MaskRay fb13be0
MC: Generalize evaluateTargetFixup
MaskRay a38cf85
[MachineLICM] Let targets decide if copy instructions are cheap (#146…
guy-david 9d994d1
[bazel] Port b9b2661f72ac5f9d4f23d9bb83131aa3d46020b9
d0k 0a067dc
[Attributor] Swap range metadata to attribute for calls. (#108835)
andjo403 e64289b
[clang][Sema] Unify getPrototypeLoc helpers in SemaCodeComplete and c…
HighCommander4 15f07db
[clang] Fix a typo in documentation (#147128)
kazutakahirata 0bc6d60
[llvm] Fix typos in documentation (#147129)
kazutakahirata c9d9c3e
[InstCombine] Fold `icmp pred X + K, Y -> icmp pred2 X, Y` if both X …
dtcxzyw 22f8ced
[libc++] Add the thread safety annotations unconditionally (#117497)
philnik777 bdbac2b
[libc++] default some special members in map and set (#147081)
philnik777 1121d64
[libc++][NFC] Merge add_{r,l}value_reference.h (#147022)
philnik777 ca69709
[libc++] Granularize <locale> (#146650)
philnik777 f17a638
[gn build] Port 1121d64ba96d
llvmgnsyncbot 113ea3d
[gn build] Port ca697096aa6f
llvmgnsyncbot 9eb4fc7
[libc++] constexpr `flat_set` (#140360)
huixie90 3448e9c
[AArch64][GlobalISel] Fix lowering of i64->f32 itofp. (#132703)
davemgreen 7d65cb1
[ARM] Copy (SELECT_CC setgt, iN lhs, -1, 1, -1) -> (OR (ASR lhs, N-1)…
AZero13 b94a9bc
ARM: Improve branch fixup test
MaskRay 38b8ef1
[mlir] Remove unused includes (NFC) (#147158)
kazutakahirata fb2c761
[clang][bytecode] Fix comparing pointers pointing to base classes (#1…
tbaederr 430c037
[Sema] Remove an unnecessary cast (NFC) (#147154)
kazutakahirata 3f4be89
AArch64AsmBackend: Remove redundant PCRelFlagVal
MaskRay 152c9d5
MC: Sink FKF_IsAlignedDownTo32Bits to needed targets
MaskRay 244e053
MC: Remove llvm/MC/MCFixupKindInfo.h
MaskRay 30298f9
MC: Simplify fragment code. NFC
MaskRay a8d434f
Merge from 'main' to 'sycl-web' (52 commits)
4f93e78
Merge from 'sycl' to 'sycl-web' (7 commits)
bwyma 5c0af3d
Merge from 'sycl' to 'sycl-web' (12 commits)
bwyma 996e3b0
Merge from 'sycl' to 'sycl-web' (1 commits)
bwyma 76d87fd
Merge from 'sycl' to 'sycl-web' (23 commits)
bwyma 37fc4d9
Merge from 'main' to 'sycl-web' (29 commits)
bwyma f6078c9
Merge from 'main' to 'sycl-web' (100 commits)
vmaksimo 0866fab
Merge from 'main' to 'sycl-web' (72 commits)
vmaksimo 5a3ed88
Merge from 'sycl' to 'sycl-web' (8 commits)
vmaksimo 9101ac8
Merge from 'main' to 'sycl-web' (36 commits)
vmaksimo 7b1d0ae
[libspirv] Fix fmin/fmax conflict
frasercrmck 1e22f0b
[libspirv] Fix ilogb conflict
frasercrmck 252d82c
[libspirv] Fix conflict in CMake
frasercrmck 5362ceb
[sycl-web] Restore command for building bc files. (#19348)
bwyma 0bdb1d2
Merge from 'main' to 'sycl-web' (56 commits)
bwyma b42d604
Merge from 'main' to 'sycl-web' (5 commits)
bwyma 5ee67eb
Merge from 'main' to 'sycl-web' (53 commits)
bwyma dfa4baa
Merge
vmaksimo f2320d5
Merge commit '30298f91367f0c320e136cbe158f1d9dbf0c3a57' into llvmspir…
vmaksimo 14e9f00
Update after ArrayRef(std::nullopt) deprecation (#3248)
svenvh 115b84e
Explicitly cast OCLMemOrderKind members from std::memory_order in C++…
jaladreips 1e42a1b
Cast the GEP base pointer to source type upon mismatch (#3255)
karolzwolak 1c89640
Ignore llvm.fake.use (#3264)
maarquitos14 70cb5e1
Add support for SPV_INTEL_function_variants (#3246)
jzadnik 1037414
Fix potential constructor ambiguity in BuiltinCallMutator::ValueTypeP…
jaladreips 76b9f31
Update LLVM version from 21 to 22 (#3265)
svenvh 6cece96
Fix build when linking against SPIRVLib with SPIR-V backend support e…
sarnex 1eda567
Adjust Lifetime intrinsic translation after 92c55a315eab (#3278)
MrSidims efafe3c
Add Check for WordCount Against SPIRV File Size (#3266)
YixingZhang007 6a8a8fc
fix conflict resolution
vmaksimo ea3768c
Refactor sycl offload (#19464)
srividya-sundaram b977937
[libclc] Sync latest sycl-web to pulldown branch
jsji 8c87679
Merge remote-tracking branch 'origin/sycl' into llvmspirv_pulldown
jsji 9d39951
X86MCCodeEmitter: Work around gcc/value-range.cc bug in GCC 13.3.0
MaskRay 090127d
[NFC][Driver] Avoid assert for invalide amd arch test
jsji c6b5e64
[Driver][SYCL] Improve diagnostic behaviors for intel_gpu targets
mdtoguchi 12c4a0e
[Driver][SYCL] Update device recognition behaviors for GPU
mdtoguchi 7dc0216
Merge branch 'sycl' into llvmspirv_pulldown
jsji 39da8be
[NFC] Remove log files
jsji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use
-nogpulib
for both? The test is just for verifying a bad argument to-fsycl-targets
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for some reason, cl mode driver does not respect -nogpulib.