Skip to content

[CI] Add libc++ build job to nightly #19628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

[CI] Add libc++ build job to nightly #19628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion .github/workflows/sycl-linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
name: Reusable SYCL Linux build workflow

defaults:
run:
shell: bash

on:
workflow_call:
inputs:
Expand Down Expand Up @@ -186,12 +190,21 @@ jobs:
- name: check-llvm
if: always() && !cancelled() && contains(inputs.changes, 'llvm')
run: |
if [[ "${{ inputs.build_configure_extra_args }}" == *"--use-libcxx"* ]]; then
# https://github.com/llvm/llvm-project/issues/59429
export LIT_FILTER_OUT="ExecutionEngine/MCJIT"
fi

cmake --build $GITHUB_WORKSPACE/build --target check-llvm
- name: check-clang
if: always() && !cancelled() && contains(inputs.changes, 'clang')
run: |
# Can we move this to Dockerfile? Hopefully, noop on Windows.
export XDG_CACHE_HOME=$GITHUB_WORKSPACE/os_cache
if [[ "${{ inputs.build_configure_extra_args }}" == *"--use-libcxx"* ]]; then
# https://github.com/llvm/llvm-project/issues/59428
export LIT_FILTER_OUT="(E|e)xception"
fi
cmake --build $GITHUB_WORKSPACE/build --target check-clang
- name: check-sycl
if: always() && !cancelled() && contains(inputs.changes, 'sycl')
Expand Down Expand Up @@ -281,7 +294,6 @@ jobs:

- name: Source OneAPI TBB vars.sh
if: ${{ inputs.e2e_binaries_artifact && always() && !cancelled() && steps.build.conclusion == 'success' }}
shell: bash
run: |
# https://github.com/actions/runner/issues/1964 prevents us from using
# the ENTRYPOINT in the image.
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/sycl-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ jobs:

artifact_archive_name: sycl_linux_oneapi.tar.zst

ubuntu2404_libcxx_build:
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl-linux-build.yml
secrets: inherit
with:
build_cache_root: "/__w/"
build_cache_suffix: libcxx
build_artifact_suffix: libcxx
build_configure_extra_args: --use-libcxx -DLLVM_SPIRV_ENABLE_LIBSPIRV_DIS=OFF
cc: clang-18
cxx: clang++-18

artifact_archive_name: sycl_linux_libcxx.tar.zst

ubuntu2204_test:
needs: [ubuntu2204_build]
if: ${{ always() && !cancelled() && needs.ubuntu2204_build.outputs.build_conclusion == 'success' }}
Expand Down
3 changes: 3 additions & 0 deletions sycl/unittests/misc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
set(sycl_lib_dir $<TARGET_FILE_DIR:sycl>)
add_definitions(-DSYCL_LIB_DIR="${sycl_lib_dir}")
# https://github.com/intel/llvm/issues/19626
if(NOT LLVM_LIBCXX_USED)
Comment on lines +3 to +4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wasn't that a part of the PR to disable tests? Is that because this build is slightly different or simply missed back then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed it in the last PR, I guess it's sporadic. I can make a PR just for this part if you'd prefer.

add_sycl_unittest(MiscTests SHARED
CircularBuffer.cpp
OsUtils.cpp
PropertyUtils.cpp
)
endif()
add_subdirectory(LinkGraph)
Loading