[SYCL][XPTI] Organize XPTI objects in one location(XPTI Registry) #19630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tovinkere
commented
Jul 29, 2025
tovinkere
commented
- Minimizes the calls to xptiRegisterStream()
- Intializes all the necessary streams and creates events needed by SYCL in one location
- Re-organized the initialization so all streams are initialized in one place. Fixes issues where streams were not being registered - Minimized the use of xptiRegisterStream by using the global setup during initialization. This should improve performance for collectors Signed-off-by: Vasanth Tovinkere <[email protected]>
Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
- Address the failing tests by fixing the checks as the streams are now initialized in XPTIRegistry - Addresses a bug in xpti::tracepoint_scope_t that caused a failure in test-e2e/Tracing/task_execution.cpp due to missing metadata Signed-off-by: Vasanth Tovinkere <[email protected]>
Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
- Updated USM allocation notifications to new APIs through xpti::framework::tracepoint_scope_t Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@KseniyaTikhomirova Can you please review so this can be merged? |
Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Vasanth Tovinkere <[email protected]>
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
tovinkere
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/llvm-gatekeepers The review comments have been addressed and the failure in the reductions is unrelated to the PR |
Contributor
|
We still need approvals from @intel/llvm-reviewers-runtime @intel/sycl-graphs-reviewers and @intel/unified-runtime-reviewers |
tovinkere
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KseniyaTikhomirova
approved these changes
Aug 26, 2025
pbalcer
approved these changes
Aug 26, 2025
Contributor
Author
|
@sarnex Looks like all the reviews are in - can this be merged now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.