Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Jul 30, 2025

Dumb interaction between github workflow variable usage in bash scripts, the variable happens to contain quotes only for the oneAPI build so that broke when I added these bash if statements. Make it a bash var to fix it.

Bad: https://github.com/intel/llvm/actions/runs/16612784850/job/47040968439 (HEAD)
Good: https://github.com/intel/llvm/actions/runs/16627822780/job/47051427259 (this PR)

@sarnex sarnex marked this pull request as ready for review July 30, 2025 17:01
@sarnex sarnex requested a review from a team as a code owner July 30, 2025 17:01
Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex sarnex merged commit b62432d into sycl Jul 30, 2025
12 of 15 checks passed
@bader bader deleted the sarnex/oneapi branch July 30, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants