[CI] Change pack_release -> release_toolchain_artifact input
#19646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unused in trunk and is only passed in `sycl-rel-nightly.yml` in `sycl-rel-*` branches (trunk version of it is an empty dummy stub). Not sure how future "release" branches are expected to get one.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Jul 30, 2025
| type: string | ||
| required: false | ||
| description: | | ||
| If provided, create an addition toolchain artifact with the same name |
There was a problem hiding this comment.
Typo?
Same for windows
Suggested change
| If provided, create an addition toolchain artifact with the same name | |
| If provided, create an additional toolchain artifact with the same name |
| required: false | ||
| description: | | ||
| If provided, create an addition toolchain artifact with the same name | ||
| (`inputs.toolchain_artifact_filename`) as `toolchain_artifact` above |
There was a problem hiding this comment.
This is a bit confusing. It's an archive name, not an artifact name, isn't it? From this sentence it seems like it creates one more "sycl_linux_default" or so. Can't we say "If provided, create an additional toolchain artifact without utilities used for testing called inputs.release_toolchain_artifact or just "If provided, create an additional toolchain artifact without utilities used for testing"?
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
@aelovikov-intel could you please also update it for win? Otherwise LGTM
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unused in trunk and is only passed in
sycl-rel-nightly.ymlinsycl-rel-*branches (trunk version of it is an empty dummy stub). Not sure how future "release" branches are expected to get one.I think making the change results in better alignment between different artifacts produced the workflow, no other reasons beyond that.