[SYCL][NFC] Move NDRDescT to include/sycl/detail/cg_types.hpp
#19665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
|
||
| // TODO: A lot of tests rely on particular values to be set for dimensions that | ||
| // are not used. To clarify, for example, if a 2D kernel is invoked, in | ||
| // NDRDescT, the value of index 2 in GlobalSize must be set to either 1 or 0 |
There was a problem hiding this comment.
I really dislike this aspect of the NDRDesc. It has THREE different applications:
- sometimes we template it to Dims
- sometimes Dim is 3, but 0 is used in the higher "unused" dimensions
- othertimes Dim is 3, and 1 is used in the higher "unused" dimensions.
IIRC, when we are hoisting it to the device it is not templated and we use that third convention. That way the sizes are correct, as multiplying by 1 doesn't change anything.
We should probably remove that second convention, the one that uses 0. That just leads to bugs. And, maybe we should reevaluate the usage of this end to end and drop the template over Dims. In one form or other, the NDRDesc is used by the FE, by SYCL and by the device.
|
Closing this as this change is covered by #20157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can include
NDRDescTin the headers, without causing circular dependency.