Skip to content

[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction #19667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction #19667

merged 3 commits into from
Aug 21, 2025

Conversation

@winstonzhang-intel
Copy link
Contributor

@winstonzhang-intel winstonzhang-intel commented Jul 31, 2025

VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport.

@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner July 31, 2025 17:42
nrspruit
nrspruit approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@nrspruit nrspruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winstonzhang-intel winstonzhang-intel requested a review from a team as a code owner August 14, 2025 20:07
@nrspruit nrspruit self-requested a review August 19, 2025 18:10
@winstonzhang-intel
[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction
8283821 
VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to
verifyCommonImagePropertiesSupport.

Signed-off-by: Zhang, Winston <[email protected]>
@winstonzhang-intel
test modification
839c72b 
Signed-off-by: Zhang, Winston <[email protected]>
@winstonzhang-intel
clang-format
28b887d 
Signed-off-by: Zhang, Winston <[email protected]>
@nrspruit
Copy link
Contributor

nrspruit commented Aug 21, 2025

@intel/llvm-gatekeepers , please merge when able.

@uditagarwal97 uditagarwal97 merged commit 8000760 into intel:sycl Aug 21, 2025
36 checks passed
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Sep 10, 2025
@winstonzhang-intel @AlexeySachkov
[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction (
470e3aa 
intel#19667)

VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to
verifyCommonImagePropertiesSupport.

---------

Signed-off-by: Zhang, Winston <[email protected]>
@AlexeySachkov AlexeySachkov mentioned this pull request Sep 10, 2025
Merged
AlexeySachkov added a commit that referenced this pull request Sep 23, 2025
@AlexeySachkov
[SYCL] Cherry-pick UR patches related to bindless images (#20031)
2976c7e 
This is a joined cherry-pick of:

---

[UR][L0] Remove Driver Exp Implementation of External Semaphore
(#19835)

- Intel L0 GPU Driver no longer supports the Driver Exp Implementation
of External Semaphore and the code has been removed from the codebase,
therefore the support needs to be removed from the adapter to allow
compiling with newer ze_intel_gpu.h headers.
- L0 Spec implementation is the only version required for customer
support.

Patch-by: Neil R. Spruit <[email protected]>

---

[UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction
(#19667)

VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to
verifyCommonImagePropertiesSupport.

Patch-by: Zhang, Winston <[email protected]>

---

[UR][L0][V2] Fixed supported logic for external semaphore
(#19863)

Patch-by: Neil R. Spruit <[email protected]>

---

[UR][L0] Fix Implict Event sync during external semaphore wait/signal
(#19859)

- When SYCl Calls the L0 adapter without a signal event, L0 creates an
internal event.
- Given in order command queue, the internal event for the wait/signal
is implicitly added to the wait list of the next command if
executeCommandList is called.
- This ensures that the internal event is properly synchronized with the
command queue during that next call given SYCL is failing to create a UR
event for tracking the wait/signal.

Patch-by: Neil R. Spruit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nrspruit nrspruit nrspruit approved these changes

+1 more reviewer

@ProGTX ProGTX ProGTX approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@winstonzhang-intel @nrspruit @ProGTX @uditagarwal97