Skip to content

[SYCL] [COMPAT]Fix the changing meaning of the declaration when building with -Wchanges-meaning #19673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 15, 2025
Merged

[SYCL] [COMPAT]Fix the changing meaning of the declaration when building with -Wchanges-meaning #19673

merged 2 commits into from
Sep 15, 2025

Conversation

@ShengchenJ
Copy link
Contributor

@ShengchenJ ShengchenJ commented Aug 1, 2025 •
edited
Loading

Fix the header file compile failed when building with "-Wchanges-meaning".

Signed-off-by: Chen, Sheng S [email protected]

@ShengchenJ ShengchenJ requested a review from a team as a code owner August 1, 2025 06:56
@ShengchenJ ShengchenJ changed the title Fix the changing meaning of the declaration when building with -Wchan… Fix the changing meaning of the declaration when building with -Wchanges-meaning Aug 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

@intel/llvm-gatekeepers please consider merging

@ShengchenJ
Copy link
Contributor Author

ShengchenJ commented Sep 9, 2025

@intel/llvm-gatekeepers, please help merge it. Many thanks.

@dm-vodopyanov
Copy link
Contributor

dm-vodopyanov commented Sep 9, 2025

@ShengchenJ, hi, please follow https://github.com/intel/llvm/blob/sycl/sycl/doc/developer/ContributeToDPCPP.md#commit-message

@ShengchenJ ShengchenJ changed the title Fix the changing meaning of the declaration when building with -Wchanges-meaning [SYCL] Fix the changing meaning of the declaration when building with -Wchanges-meaning Sep 9, 2025
@ShengchenJ ShengchenJ changed the title [SYCL] Fix the changing meaning of the declaration when building with -Wchanges-meaning [SYCL] [COMPAT]Fix the changing meaning of the declaration when building with -Wchanges-meaning Sep 9, 2025
@sarnex
Copy link
Contributor

sarnex commented Sep 9, 2025

Can we add a PR description too

@ShengchenJ
Copy link
Contributor Author

ShengchenJ commented Sep 10, 2025

Can we add a PR description too

Done.

@airMeng airMeng mentioned this pull request Sep 10, 2025
Merged
@ShengchenJ
Copy link
Contributor Author

ShengchenJ commented Sep 15, 2025

@intel/llvm-gatekeepers could you help review again?

@steffenlarsen steffenlarsen merged commit 5c5e364 into intel:sycl Sep 15, 2025
27 checks passed
@ShengchenJ ShengchenJ deleted the fix_duplicate_name branch September 16, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

+5 more reviewers

@ProGTX ProGTX ProGTX approved these changes

@polisettyvarma polisettyvarma polisettyvarma approved these changes

@zhimingwang36 zhimingwang36 zhimingwang36 approved these changes

@airMeng airMeng airMeng approved these changes

@zhiweij1 zhiweij1 zhiweij1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@ShengchenJ @dm-vodopyanov @sarnex @ProGTX @polisettyvarma @zhimingwang36 @airMeng @steffenlarsen @zhiweij1