Skip to content

[GDB] Fix pretty-printer crash for sycl::item MOffset #19683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 12, 2025
+37 −4
Merged

[GDB] Fix pretty-printer crash for sycl::item MOffset #19683

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3e1892
Fix sycl::item gdb pretty-printer finding MOffset
ianayl Aug 1, 2025
643519e
Add sycl::item checking to test/gdb/printers.cpp
ianayl Aug 7, 2025
8c3aad8
Apply suggestions from code review
ianayl Aug 7, 2025
8d1cb03
apply clang-format
ianayl Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sycl/gdb/libsycl.so-gdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1074,10 +1074,13 @@ def to_string(self):
string = self.type_name(self.gdb_type())
extent = SYCLRangePrinter(sycl_item.extent()).value_as_string()
string += " range " + extent
offset_id = SYCLItem(self.gdb_value()).offset()
offset = SYCLIdPrinter(offset_id).value_as_string()
if offset not in ["0", "{0, 0}", "{0, 0, 0}"]:
string += ", offset " + offset
try:
offset_id = SYCLItem(self.gdb_value()).offset()
offset = SYCLIdPrinter(offset_id).value_as_string()
if offset not in ["0", "{0, 0}", "{0, 0, 0}"]:
string += ", offset " + offset
except:
pass # device offset disabled
string += " = " + self.value_as_string()
return string

Expand Down