Skip to content

[CI] Add "Nightly" releases support for manual runs of sycl-linux-run-tests.yml #19690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025
Merged

[CI] Add "Nightly" releases support for manual runs of sycl-linux-run-tests.yml #19690

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/workflows/sycl-linux-run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ on:
- e2e
- cts
- benchmarks
toolchain_release_tag:
description: |
Tag of a "Nightly" release at https://github.com/intel/llvm/releases.
default: ''

env:
description: |
Expand Down Expand Up @@ -256,11 +260,6 @@ jobs:
uses: actions/download-artifact@v4
with:
name: ${{ inputs.toolchain_artifact }}
- name: Debug prints [workflow_run]
if: inputs.toolchain_artifact != '' && github.event_name == 'workflow_run'
run: |
pwd
ls
- name: Download SYCL toolchain [workflow_run]
# NOTE: This is for `sycl-linux-precommit-aws.yml`.
if: inputs.toolchain_artifact != '' && github.event_name == 'workflow_run'
Expand Down Expand Up @@ -299,6 +298,17 @@ jobs:
rm -f ${{ inputs.toolchain_artifact_filename }}
echo PATH=$PWD/toolchain/bin/:$PATH >> $GITHUB_ENV
echo LD_LIBRARY_PATH=$PWD/toolchain/lib/:$LD_LIBRARY_PATH >> $GITHUB_ENV
- name: Download SYCL toolchain using release tag
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this step and the previous be mutually exclusive? What does it mean if both Extract/Setup SYCL toolchain and Download SYCL toolchain using release tag run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, they kind of are exclusive. Artifact is only set for workflow_call trigger and release tag for workflow_dispatch.

Copy link
Contributor

@sarnex sarnex Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set up the toolchain in a single step with an bash if statement to check which variable is set?

Copy link
Contributor Author

@aelovikov-intel aelovikov-intel Aug 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had something like that in my first version locally, but I didn't like it because the artifact download code is still in separate steps. See lines 258 and 263/286. I could have had three different downloads steps and a single export PATH step, but that wouldn't be any better than what I have in this PR, IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok yeah i see the problem, combining the three cases (using build step artifact from workflow call, using build step artifact from workflow dispatch, using nightly for workflow dispatch) would be pretty annoying, i guess some of it is our fault for trying to support a ton of cases but github definitely does not make it easy

if: inputs.toolchain_release_tag != ''
env:
TAG: ${{ inputs.toolchain_release_tag }}
shell: bash
run: |
mkdir toolchain
wget "https://github.com/intel/llvm/releases/download/$TAG/sycl_linux.tar.gz"
tar xf sycl_linux.tar.gz -C toolchain
echo PATH=$PWD/toolchain/bin/:$PATH >> $GITHUB_ENV
echo LD_LIBRARY_PATH=$PWD/toolchain/lib/:$LD_LIBRARY_PATH >> $GITHUB_ENV
- run: which clang++ sycl-ls
- run: sycl-ls --verbose
- run: SYCL_UR_TRACE=1 sycl-ls
Expand Down
Loading