Skip to content

Conversation

gmlueck
Copy link
Contributor

@gmlueck gmlueck commented Aug 4, 2025

Fix a few syntax errors in the example for this extension.

Fix a few syntax errors in the example for this extension.
@gmlueck gmlueck requested a review from a team as a code owner August 4, 2025 18:24
@gmlueck
Copy link
Contributor Author

gmlueck commented Aug 4, 2025

@intel/llvm-gatekeepers : It seems like the error with "Generate documentation" is unrelated to this PR. I think it is caused by 9df2111, which bumped the version of "docutils" from 0.21.2 to 0.22. According to the error message, this version of docutils is incompatible with our version of Sphinx (8.1.3).

@sarnex
Copy link
Contributor

sarnex commented Aug 4, 2025

I'll see if I can fix it, thanks for the report.

Copy link
Contributor

@jbrodman jbrodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarnex added a commit that referenced this pull request Aug 4, 2025
It bumped the docutiils version to 0.22 but there is no release of
`sphinx` that supports 0.22.

The next `sphinx` release should have it.

Doc CI is broken because of this, see
#19701

Signed-off-by: Sarnie, Nick <[email protected]>
@gmlueck
Copy link
Contributor Author

gmlueck commented Aug 4, 2025

@intel/llvm-gatekeepers : I think this is ready to merge, assuming you agree with me about the test failure.

@sarnex sarnex merged commit d8d1c3d into intel:sycl Aug 4, 2025
3 of 4 checks passed
@gmlueck gmlueck deleted the gmlueck/fix-device-image-content-example branch August 4, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants