[SYCL] variadic_iterator noexcept #19706
Open
+5
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cept, some being API. Changing its operator++ to be noexcept to prevent issues and put Coverity's mind at ease
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
Windows unit test SchedulerTests.exe failure is known ( CMPLRLLVM-69554) , flaky, under investigation, and in main syclos branch right now. I have this PR for the CMPLRLLVM-69554 : #19762 . Once it is merged, then the unit tests on this PR could be re-run and it should be passing ( assuming the CI refreshes the unit test builds and no other conflicts are introduced in the interim) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variadic_iterator was recently introduced and is used by several routines that are marked as noexcept, some being API. Changing its operator++ to be noexcept to prevent issues and put Coverity's mind at ease