[SYCL] Avoid illegal order in compare_exchange_* #19723
Open
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The atomic_ref compare_exchange_* functions, which take only one memory order argument, call the respective compare_exchange_* functions, which take two memory order arguments, and use the same order for both the success and failure memory orders. This might result in UB, where the 'acquire' or 'release' failure order is used. This commit ensures that an illegal failure order is never passed.
|
Hold off on merging until KhronosGroup/SYCL-Docs#891 is merged. This is a follow up PR to intel/llvm#19513. |
|
Ready to review @sergey-semenov. This PR directly implements the clarification from KhronosGroup/SYCL-Docs#891. |
Pennycook
approved these changes
Aug 11, 2025
sergey-semenov
approved these changes
Aug 11, 2025
robertszafa
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
robertszafa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
robertszafa
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomic_ref compare_exchange_* functions, which take only one memory order argument, call the respective compare_exchange_* functions, which take two memory order arguments, and use the same order for both the success and failure memory orders. This might result in UB where the 'acquire' or 'release' failure order is used. This commit ensures that an illegal failure order is never passed.