[SYCL] Simplify detection of device bitcode libraries for RTC #19756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2025 08:28
…49294) This patch provides a single point for handling the logic behind choosing common bitcode libraries. The intention is that the users of ROCm installation detector will not have to rewrite options handling code each time the bitcode libraries are queried. This is not too distant from detectors for other architecture that encapsulate the similar decision making process, providing cleaner interface. The only flag left in `getCommonBitcodeLibs` (main point of entry) is `NeedsASanRT`, this is deliberate, as in order to calculate it we need to consult `ToolChain`.
…51114) This patch moves `LazyDetector` and target specific (Cuda, Hip, SYCL) installation detectors to clang's include directory. It was problematic for downstream to use headers from clang's lib dir. The use of lib headers could lead to subtle errors, as some of the symbols there are annotated with `LLVM_LIBRARY_VISIBILITY`. For instance [`ROCMToolChain::getCommonDeviceLibNames`](https://github.com/jchlanda/llvm-project/blob/jakub/installation_detectors/clang/lib/Driver/ToolChains/AMDGPU.h#L147) is c++ public, but because of the annotation it ends up as ELF hidden symbol, which causes errors when accessed from another shared library.
Contributor
Author
|
Please note that the first two commits are cherry-picks from upstream llvm: llvm/llvm-project#149294 and llvm/llvm-project#151114. |
jchlanda
force-pushed
the
jakub/rtc_lazy_detectors
branch
from
82a4a32 to
0e0a961
Compare
jchlanda
force-pushed
the
jakub/rtc_lazy_detectors
branch
from
0e0a961 to
912b04d
Compare
By using installation detectors we can move away from creating full toolchains and querying them.
sommerlukas
approved these changes
Aug 11, 2025
Contributor
sommerlukas
left a comment
sommerlukas
left a comment
There was a problem hiding this comment.
LGTM.
I focused my review on 912b04d, as the other two commits were already reviewed in upstream LLVM.
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to go. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using installation detectors we can move away from creating full toolchains and querying them.