Skip to content
Draft
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions sycl/include/sycl/ext/oneapi/experimental/rangesref.hpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
//==-------- rangesref.hpp --- SYCL iteration with reference to ranges -----==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//

#pragma once

#include <sycl/nd_range.hpp>

namespace sycl {
inline namespace _V1 {
namespace ext::oneapi::experimental {

// The structure to keep references to ranges and dimension unified for
// all dimensions.
class RangesRefT {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking out load, would it be better to call this class ranges_ref_view? Since this class is just a "view" over the user-provided range and doesn't own the lifetime of the underlying range object. Similar to how string_view or ranges::ref_view (https://www.en.cppreference.com/w/cpp/ranges/ref_view.html) works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done.


public:
RangesRefT() = default;
RangesRefT(const RangesRefT &Desc) = default;
RangesRefT(RangesRefT &&Desc) = default;

template <int Dims_>
RangesRefT(sycl::range<Dims_> &GlobalSizes, sycl::range<Dims_> &LocalSizes)
: GlobalSize(&(GlobalSizes[0])), LocalSize(&(LocalSizes[0])),
Dims{size_t(Dims_)} {}

// to support usage in sycl::ext::oneapi::experimental::submit_with_event()
template <int Dims_>
RangesRefT(sycl::nd_range<Dims_> &ExecutionRange)
: GlobalSize(&ExecutionRange.globalSize[0]),
LocalSize(&ExecutionRange.localSize[0]),
GlobalOffset(&ExecutionRange.offset[0]), Dims{size_t(Dims_)} {}

template <int Dims_>
RangesRefT(sycl::range<Dims_> &Range)
: GlobalSize(&(Range[0])), Dims{size_t(Dims_)} {}

RangesRefT &operator=(const RangesRefT &Desc) = default;
RangesRefT &operator=(RangesRefT &&Desc) = default;

const size_t *GlobalSize = nullptr;
const size_t *LocalSize = nullptr;
const size_t *GlobalOffset = nullptr;
size_t Dims = 0;
};

} // namespace ext::oneapi::experimental
} // namespace _V1
} // namespace sycl
6 changes: 6 additions & 0 deletions sycl/include/sycl/nd_range.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
namespace sycl {
inline namespace _V1 {

namespace ext::oneapi::experimental {
class RangesRefT;
}

/// Defines the iteration domain of both the work-groups and the overall
/// dispatch.
///
Expand Down Expand Up @@ -65,6 +69,8 @@ template <int Dimensions = 1> class nd_range {
bool operator!=(const nd_range<Dimensions> &rhs) const {
return !(*this == rhs);
}

friend class sycl::_V1::ext::oneapi::experimental::RangesRefT;
};

} // namespace _V1
Expand Down
1 change: 1 addition & 0 deletions sycl/unittests/scheduler/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,5 @@ add_sycl_unittest(SchedulerTests OBJECT
AccessorDefaultCtor.cpp
HostTaskAndBarrier.cpp
BarrierDependencies.cpp
RangesRefUsage.cpp
)
112 changes: 112 additions & 0 deletions sycl/unittests/scheduler/RangesRefUsage.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
//==---- RangesRefUsage.cpp --- Check RangesRefT --------------------------==//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include <sycl/ext/oneapi/experimental/rangesref.hpp>

#include <gtest/gtest.h>

TEST(RangesRefUsage, RangesRefUsage) {
sycl::ext::oneapi::experimental::RangesRefT r0;
ASSERT_EQ(r0.Dims, size_t{0});

{
sycl::range<1> global_range{1024};
sycl::range<1> local_range{64};
sycl::id<1> offset{10};
sycl::nd_range<1> nd_range{global_range, local_range, offset};

{
sycl::ext::oneapi::experimental::RangesRefT r{nd_range};
ASSERT_EQ(r.Dims, size_t{1});
ASSERT_EQ(*r.GlobalSize, global_range[0]);
ASSERT_EQ(*r.LocalSize, local_range[0]);
ASSERT_EQ(*r.GlobalOffset, offset[0]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range, local_range};
ASSERT_EQ(r.Dims, size_t{1});
ASSERT_EQ(*r.GlobalSize, global_range[0]);
ASSERT_EQ(*r.LocalSize, local_range[0]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range};
ASSERT_EQ(r.Dims, size_t{1});
ASSERT_EQ(*r.GlobalSize, global_range[0]);
ASSERT_EQ(r.LocalSize, nullptr);
}
}
{
sycl::range<2> global_range{1024, 512};
sycl::range<2> local_range{64, 32};
sycl::id<2> offset{10, 20};
sycl::nd_range<2> nd_range{global_range, local_range, offset};

{
sycl::ext::oneapi::experimental::RangesRefT r{nd_range};
ASSERT_EQ(r.Dims, size_t{2});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.LocalSize[0], local_range[0]);
ASSERT_EQ(r.LocalSize[1], local_range[1]);
ASSERT_EQ(r.GlobalOffset[0], offset[0]);
ASSERT_EQ(r.GlobalOffset[1], offset[1]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range, local_range};
ASSERT_EQ(r.Dims, size_t{2});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.LocalSize[0], local_range[0]);
ASSERT_EQ(r.LocalSize[1], local_range[1]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range};
ASSERT_EQ(r.Dims, size_t{2});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.LocalSize, nullptr);
}
}
{
sycl::range<3> global_range{1024, 512, 256};
sycl::range<3> local_range{64, 32, 16};
sycl::id<3> offset{10, 20, 30};
sycl::nd_range<3> nd_range{global_range, local_range, offset};

{
sycl::ext::oneapi::experimental::RangesRefT r{nd_range};
ASSERT_EQ(r.Dims, size_t{3});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.GlobalSize[2], global_range[2]);
ASSERT_EQ(r.LocalSize[0], local_range[0]);
ASSERT_EQ(r.LocalSize[1], local_range[1]);
ASSERT_EQ(r.LocalSize[2], local_range[2]);
ASSERT_EQ(r.GlobalOffset[0], offset[0]);
ASSERT_EQ(r.GlobalOffset[1], offset[1]);
ASSERT_EQ(r.GlobalOffset[2], offset[2]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range, local_range};
ASSERT_EQ(r.Dims, size_t{3});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.GlobalSize[2], global_range[2]);
ASSERT_EQ(r.LocalSize[0], local_range[0]);
ASSERT_EQ(r.LocalSize[1], local_range[1]);
ASSERT_EQ(r.LocalSize[2], local_range[2]);
}
{
sycl::ext::oneapi::experimental::RangesRefT r{global_range};
ASSERT_EQ(r.Dims, size_t{3});
ASSERT_EQ(r.GlobalSize[0], global_range[0]);
ASSERT_EQ(r.GlobalSize[1], global_range[1]);
ASSERT_EQ(r.GlobalSize[2], global_range[2]);
ASSERT_EQ(r.LocalSize, nullptr);
}
}
}
Loading