[NFC][SYCL] Add sycl::detail::sycl_obj_hash helper
#19812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, can't simplify further in C++17.
In C++20 that could be changed to
```
template <class T>
requires(is_sycl_common_reference_semantics_class_v<T>)
struct std::hash<T> {
// sycl_obj_hash impl inlined here.
};
```
But even in C++17 this PR removes copy-paste and places the
implementation in a single place.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
reviewed
Aug 18, 2025
| return createSyclObjFromImpl<T>(ImplRef.shared_from_this()); | ||
| } | ||
|
|
||
| template <typename T, bool UnsupportedOnDevice = false> struct sycl_obj_hash { |
Contributor
There was a problem hiding this comment.
Please consider bool SupportedOnDevice = true, instead of double negation.
Contributor
Author
There was a problem hiding this comment.
I'm optimizing for the readability on the invocation here. IMO,
template std::hash<type> : sycl_obj_has<type, true /* UnsupportedOnDevice */> {}
reads better. @intel/llvm-reviewers-runtime , is there anybody who prefers @slawekptak's version more?
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/bindless-images-reviewers , ping. |
slawekptak
approved these changes
Aug 18, 2025
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
Ping x2 |
przemektmalon
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, can't simplify further in C++17.
In C++20 that could be changed to
But even in C++17 this PR removes copy-paste and places the implementation in a single place.