Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Aug 18, 2025

The function "SYCL::getSYCLDeviceLibraries" is more than 350 Loc now, this PR splits the logic of linking sanitizer libraries from it to do a little simplification.

@jinge90 jinge90 requested a review from a team as a code owner August 18, 2025 06:18
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 18, 2025

Hi, @intel/dpcpp-clang-driver-reviewers
Could you help review this PR?
Thanks very much.

@jinge90 jinge90 requested a review from mdtoguchi August 19, 2025 00:51
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 19, 2025

Hi, @mdtoguchi
Could you help review this trivial PR?
Thanks very much.

@jinge90 jinge90 requested a review from mdtoguchi August 20, 2025 01:55
@jinge90 jinge90 requested a review from a team August 20, 2025 15:41
@jinge90
Copy link
Contributor Author

jinge90 commented Aug 20, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@uditagarwal97 uditagarwal97 merged commit 47a172b into intel:sycl Aug 20, 2025
61 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants