[UR][L0] Event cleanup in urEnqueueKernelLaunch #19827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
nrspruit
reviewed
Aug 19, 2025
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
winstonzhang-intel
force-pushed
the
642
branch
from
90e5349 to
ea87fce
Compare
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
force-pushed
the
642
branch
from
3d95223 to
ebea5a0
Compare
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
nrspruit
reviewed
Aug 26, 2025
nrspruit
reviewed
Aug 26, 2025
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
force-pushed
the
642
branch
from
809c0c5 to
ebc5c20
Compare
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
force-pushed
the
642
branch
from
ebc5c20 to
f9a2eeb
Compare
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
force-pushed
the
642
branch
from
f9a2eeb to
c7a28d2
Compare
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
force-pushed
the
642
branch
from
88e1d22 to
c01fc27
Compare
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
When using internal events we do not clean up after execution. In the case of repeated call to urEnqueueKernelLaunch we eventually return UR_RESULT_ERROR_OUT_OF_RESOURCES. The cleanup is done when we call zeEventPoolCreate. Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
force-pushed
the
642
branch
from
c01fc27 to
6680836
Compare
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
nrspruit
approved these changes
Sep 4, 2025
|
@intel/llvm-gatekeepers Patch is ready. Please merge when possible. Thanks! |
|
@intel/llvm-gatekeepers , please merge when available, the issue in the CI is a build issue unrelated to this change. |
|
Yep that issue should be fixed in HEAD, definitely unrelated/ |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 30, 2025
When using internal events we do not clean up after execution. In the case of repeated call to urEnqueueKernelLaunch we eventually return UR_RESULT_ERROR_OUT_OF_RESOURCES. --------- Signed-off-by: Zhang, Winston <[email protected]>
AlexeySachkov
added a commit
that referenced
this pull request
Oct 27, 2025
This is a joint cherry-pick of #18325 and #19827 --- [UR][L0] Event pool cache leak fix (#18325) addresses event pool leak when SYCL_PI_LEVEL_ZERO_DISABLE_EVENTS_CACHING is set to 1 --- [UR][L0] Event cleanup in urEnqueueKernelLaunch (#19827) When using internal events we do not clean up after execution. In the case of repeated call to urEnqueueKernelLaunch we eventually return UR_RESULT_ERROR_OUT_OF_RESOURCES. --------- Patch-by: Zhang, Winston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using internal events we do not clean up after execution. In the case of repeated call to urEnqueueKernelLaunch we eventually return UR_RESULT_ERROR_OUT_OF_RESOURCES.