[UR][Offload] Various small fixes for offload adapter #19832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Some functions were added, the barrier event now is reference counted (rather than being dropped when the event is destroyed) and empty events no longer cause an error.
RossBrunton
force-pushed
the
offloadMisc
branch
from
e0d2c05 to
bf45c90
Compare
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
RossBrunton
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
RossBrunton
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
callumfare
approved these changes
Aug 20, 2025
| urEventRetain(BarrierEvent); | ||
| } else { | ||
| OL_RETURN_ON_ERR(olCreateEvent(TargetQueue, &BarrierEvent)); | ||
| OL_RETURN_ON_ERR(makeEvent(TYPE, TargetQueue, hQueue, &BarrierEvent)); |
Contributor
There was a problem hiding this comment.
Nitpick: I know it's not added in this PR but the all caps name TYPE for a constexpr enum looks odd
Contributor
Author
There was a problem hiding this comment.
It's a template parameter, so in my head it inherits the naming scheme of enum variants which are all caps. Although I can't exactly say why I think it should work that way.
Contributor
Author
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions were added, the barrier event now is reference counted
(rather than being dropped when the event is destroyed) and empty events
no longer cause an error.