[UR][L0] Remove Driver Exp Implementation of External Semaphore #19835
Conversation
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
@intel/bindless-images-reviewers please review |
A short PR description would be useful here. Why were two implementations required before? And why is only one required now? |
Hello @przemektmalon , the driver experimental version was the initial implementation until the L0 spec had the support officially. Now that the L0 gpu driver supports the L0 spec version, the Driver Experimental version was deleted from the code base in the gpu driver and the definitions of the driver experimental external semaphore functions and structures no longer exist. We have to remove the usage of the old driver exp code otherwise the code will not compile if one updates the ze_intel_gpu.h headers used. |
|
@intel/llvm-gatekeepers , please merge |
…l#19835) - Intel L0 GPU Driver no longer supports the Driver Exp Implementation of External Semaphore and the code has been removed from the codebase, therefore the support needs to be removed from the adapter to allow compiling with newer ze_intel_gpu.h headers. - L0 Spec implementation is the only version required for customer support. Signed-off-by: Neil R. Spruit <[email protected]>
This is a joined cherry-pick of: --- [UR][L0] Remove Driver Exp Implementation of External Semaphore (#19835) - Intel L0 GPU Driver no longer supports the Driver Exp Implementation of External Semaphore and the code has been removed from the codebase, therefore the support needs to be removed from the adapter to allow compiling with newer ze_intel_gpu.h headers. - L0 Spec implementation is the only version required for customer support. Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction (#19667) VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport. Patch-by: Zhang, Winston <[email protected]> --- [UR][L0][V2] Fixed supported logic for external semaphore (#19863) Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] Fix Implict Event sync during external semaphore wait/signal (#19859) - When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event. - Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called. - This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal. Patch-by: Neil R. Spruit <[email protected]>
3 participants
Uh oh!
There was an error while loading. Please reload this page.