Skip to content

Conversation

@coldav
Copy link

@coldav coldav commented Aug 20, 2025

It is desirable to decouple native cpu from needing to fetch the external oneAPI Construction Kit to allow it to be maintained more smoothly.

To allow a smooth port, much of the files have been copied verbatim, but with a different use of cmake to git in with llvm components. There is a great deal of tidying up that will be required after this port to fit better in with LLVM and prune what is not necessary.

Some documentation has been added, but this will be built upon in future commits.

Colin Davidson added 2 commits August 20, 2025 16:06
It is desirable to decouple native cpu from needing to fetch the external
oneAPI Construction Kit to allow it to be maintained more smoothly.

To allow a smooth port, much of the files have been copied verbatim, but with
a different use of cmake to git in with llvm components. There is a great
deal of tidying up that will be required after this port to fit better
in with LLVM and prune what is not necessary.

Some documentation has been added, but this will be built upon in future
commits.
@coldav coldav requested a review from steffenlarsen August 20, 2025 15:13
@coldav coldav requested a review from a team as a code owner August 20, 2025 15:13
@coldav coldav changed the title DRAFT: [SYCL][NATIVECPU] Port ock compiler internals into sycl native cpu [SYCL][NATIVECPU] Port ock compiler internals into sycl native cpu Aug 20, 2025
@coldav coldav requested a review from a team as a code owner August 20, 2025 16:54
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be done by copying (and hence GH PR makes little sense), we need to preserve git history. Please look at how sycl/test-e2e was added.

@coldav
Copy link
Author

coldav commented Aug 21, 2025

This shouldn't be done by copying (and hence GH PR makes little sense), we need to preserve git history. Please look at how sycl/test-e2e was added.

I can look into a subtree, I was worried about dragging in the whole of ock for just a few files (also we scrapped history before 2023 when we went open source). I have a limited time-scale so I still think it's useful to look at this PR to see what the final merge might look like - it would probably make sense to make a new PR with the history in it. Also note after all these changes I have made to prune it, it would be almost impossible to subtree merge again.

Note there is some code_formatter fails due to use of undef. I'm not sure what to do with that or if there is a way to disable it or ignore it in the short term.

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Aug 21, 2025

#8782 is how I moved it back then, I didn't use "subtree" but I "filtered" the repo to keep only files we needed.

It was a PR, but I think we temporarily changed merged strategy from "squash" to "merge". Maybe "/merge" can do that now without changing any settings.

@coldav
Copy link
Author

coldav commented Aug 22, 2025

okay I am closing this one, so I can create a new one with history, which I'll do next week. Thanks for the feedback.

@coldav coldav closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants