[SYCL] Fix for free_function_host_compiler lit test #19848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The issue was reported in ticket: CMPLRTST-27724 |
steffenlarsen
approved these changes
Aug 22, 2025
Contributor
Author
|
I guess this failure isn't unrelated because my patch changes test behaviour but failure is related to other test |
Contributor
Author
|
Ok, all pre-commit tests finally passed. Can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue when g++ is used as host compiler and its version does not support C++17 by default.
So by adding this flag
-fsycl-host-compiler-options="-std=c++17"we ensure that the lit test is compiled with C++17 standard which is required by SYCL.