[UR][L0] Fix Implict Event sync during external semaphore wait/signal #19859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Aug 22, 2025
nrspruit
commented
- When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event.
- Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called.
- This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal.
- When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event. - Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called. - This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal. Signed-off-by: Neil R. Spruit <[email protected]>
|
Are there any unit or conformance tests that test the issue this PR fixes? |
Contributor
Author
https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/bindless_images/vulkan_interop/unsampled_images.cpp will reproduce the issue, however only sporadically so that means a new CTS is needed to validate the sycl side does not get executed before the Vulkan dependency is executed. |
Contributor
Author
|
it should be noted, that while this is needed to fix the issue for L0 indirect internal events, the root bug is that external semaphores in sycl are not implemented properly. |
Contributor
Author
|
@intel/bindless-images-reviewers , please review, this addresses the missing support for internal events given external semaphore. I will be working on adding a CTS to cover this gap in another review, but adding that CTS will result in new failures since the larger bug is in the SYCL layer itself. |
przemektmalon
approved these changes
Aug 28, 2025
Contributor
Author
|
@intel/llvm-gatekeepers please merge when available, thank you! |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 10, 2025
…intel#19859) - When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event. - Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called. - This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal. Signed-off-by: Neil R. Spruit <[email protected]>
AlexeySachkov
added a commit
that referenced
this pull request
Sep 23, 2025
This is a joined cherry-pick of: --- [UR][L0] Remove Driver Exp Implementation of External Semaphore (#19835) - Intel L0 GPU Driver no longer supports the Driver Exp Implementation of External Semaphore and the code has been removed from the codebase, therefore the support needs to be removed from the adapter to allow compiling with newer ze_intel_gpu.h headers. - L0 Spec implementation is the only version required for customer support. Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] urBindlessImagesGetImageMemoryHandleTypeSupportExp correction (#19667) VK_FORMAT_R8G8B8A8_UNORM is supported on L0 urt, correction to verifyCommonImagePropertiesSupport. Patch-by: Zhang, Winston <[email protected]> --- [UR][L0][V2] Fixed supported logic for external semaphore (#19863) Patch-by: Neil R. Spruit <[email protected]> --- [UR][L0] Fix Implict Event sync during external semaphore wait/signal (#19859) - When SYCl Calls the L0 adapter without a signal event, L0 creates an internal event. - Given in order command queue, the internal event for the wait/signal is implicitly added to the wait list of the next command if executeCommandList is called. - This ensures that the internal event is properly synchronized with the command queue during that next call given SYCL is failing to create a UR event for tracking the wait/signal. Patch-by: Neil R. Spruit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.