Skip to content

[SYCL] Add ABI symbols tests against release branch #19860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2025
Merged

[SYCL] Add ABI symbols tests against release branch #19860

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
38547e5
[SYCL] Add ABI symbols tests against release branch
aelovikov-intel Aug 22, 2025
901e4a4
Update CODEOWNERS and limit fetch depth
aelovikov-intel Aug 25, 2025
99aa55e
Align with recent sycl-rel-6_3 update
aelovikov-intel Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,3 +226,4 @@ sycl/test-e2e/ThreadSanitizer/ @intel/dpcpp-sanitizers-review

# ABI compatibility
devops/compat_ci_exclude.sycl-rel-** @gmlueck @xtian-github
sycl/test/abi/*sycl-rel*.dump @gmlueck @xtian-github
15 changes: 15 additions & 0 deletions .github/workflows/sycl-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,21 @@ on:
permissions: read-all

jobs:
check_abi_symbols:
name: Check ABI symbols tests match release branch
runs-on: [Linux, build]
if: github.repository == 'intel/llvm'
container: ghcr.io/intel/llvm/ubuntu2404_build
steps:
- uses: actions/checkout@v4
with:
sparse-checkout: |
sycl/test/abi
- run: |
git fetch origin sycl-rel-6_3
git diff --exit-code -I "^# RUN" origin/sycl-rel-6_3:sycl/test/abi/sycl_symbols_linux.dump sycl/test/abi/sycl_symbols_linux-sycl-rel-6_3.dump
git diff --exit-code -I "^# RUN" origin/sycl-rel-6_3:sycl/test/abi/sycl_symbols_windows.dump sycl/test/abi/sycl_symbols_windows-sycl-rel-6_3.dump
Copy link
Contributor Author

@aelovikov-intel aelovikov-intel Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified pass in https://github.com/intel/llvm/actions/runs/17161188384/job/48690624194

Verified "expected/intentional" fail in https://github.com/intel/llvm/actions/runs/17161006785

Copy link
Contributor

@uditagarwal97 uditagarwal97 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Instead of hardcoding the release version (6.3), can we like have a variable: Something like:

LAST_SYCL_REL_VER="6_3"
git fetch origin sycl-rel-$LAST_SYCL_REL_VER
git diff --exit-code -I "^# RUN" origin/sycl-rel-$LAST_SYCL_REL_VER:sycl/test/abi/sycl_symbols_linux.dump sycl/test/abi/sycl_symbols_linux-sycl-rel-$LAST_SYCL_REL_VER.dump
git diff --exit-code -I "^# RUN" origin/sycl-rel-$LAST_SYCL_REL_VER:sycl/test/abi/sycl_symbols_windows.dump sycl/test/abi/sycl_symbols_windows-sycl-rel-$LAST_SYCL_REL_VER.dump

It would make it easier to update the release version for future releases.

Copy link
Contributor Author

@aelovikov-intel aelovikov-intel Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave it to the next update. Not exactly sure how it's going to look like. The code-duplication is isolated, and we can remove it if it starts to grow.


ubuntu2204_build:
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl-linux-build.yml
Expand Down
Loading
Loading