[SYCL] Update detail::string_view impl
#19878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix potential `nullptr` dereference when casting default-constructed object to `std::string_view`. * Make that conversion operator implicit (because why shouldn't it be?) * Not that it's implicit, there is no need in comparison operators with `std::string_view`, because that conversion will be considered implicitly. I also have no idea why there was `__INTEL_PREVIEW_BREAKING_CHANGES` guard before.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
Also tagging @Alexandr-Konovalov as can't add him to the reviewers. |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
againull
approved these changes
Aug 25, 2025
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullptrdereference when casting default-constructed object tostd::string_view.std::string_view, because that conversion will be considered implicitly.I also have no idea why there was
__INTEL_PREVIEW_BREAKING_CHANGESguard before.