[SYCL] Fixes for usm_allocator properties
#19890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
* Fix `verifyUSMAllocatorProperties` to allow supported properties * No need to specialize `is_property<...>` for USM properties - `std::base_of_v<>`-based implementation covers that.
aelovikov-intel
force-pushed
the
usm-allocator
branch
from
a5862bc to
8c1c2ac
Compare
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| sycl::usm_allocator<int, sycl::usm::alloc::shared> allocator{ | ||
| q, | ||
| {sycl::ext::oneapi::property::usm::device_read_only{}, | ||
| sycl::ext::intel::experimental::property::usm::buffer_location{1}}}; |
Contributor
There was a problem hiding this comment.
There are some E2E tests for these properties (see for example Adapters/level_zero/usm_device_read_only.cpp and USM/buffer_location.cpp). Could these get some test cases with the allocator as well? Primarily I want to make sure the properties are being passed correctly to the allocations.
Contributor
Author
There was a problem hiding this comment.
I agree with the device_read_only part, but the buffer_location test doesn't verify anything (and is poorly written) and that is an FPGA extension, and we've deprecated whole FPGA support anyway.
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
aelovikov-intel
force-pushed
the
usm-allocator
branch
from
b17879a to
1ae0565
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
pbalcer
approved these changes
Aug 28, 2025
Contributor
Author
|
Ping @cperkinsintel . Note that @steffenlarsen is OOO till Monday so he won't be able to review this, I think. |
cperkinsintel
approved these changes
Aug 28, 2025
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 9, 2025
* Fix `verifyUSMAllocatorProperties` to allow supported properties * No need to specialize `is_property<...>` for USM properties - `std::base_of_v<>`-based implementation covers that.
AlexeySachkov
added a commit
that referenced
this pull request
Sep 10, 2025
This is a cherry-pick of #19890 * Fix `verifyUSMAllocatorProperties` to allow supported properties * No need to specialize `is_property<...>` for USM properties - `std::base_of_v<>`-based implementation covers that. Patch-by: Andrei Elovikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verifyUSMAllocatorPropertiesto allow supported propertiesis_property<...>for USM properties -std::base_of_v<>-based implementation covers that.