[SYCL] call asynchronous exception handler from ~queue, not ~queue_impl #19896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Presently we do this in ~queue_impl, which isn't exactly compliant with spec, because it's possible that queue_impl may outlive queue because of shared pointer. Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Chris Perkins <[email protected]>
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Perkins, Chris <[email protected]>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Chris Perkins <[email protected]>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
queue often has intermediate instances and having each call the async destructor is not optimal. I added simple tracking of the construction path to a different branch, but that breaks ABI. Plus, the initial comments on the spec clarification over on SYCL-DOC make me think that is an unlikely choice. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#subsubsec:exception.async
According to section 4.13.1.1 ~queue destructor is supposed to call asynchronous exception handler. Presently we do this in ~queue_impl, which isn't exactly compliant with spec, because it's possible that
queue_implmay outlive queue because of shared pointer.This error was discovered in a flaky CTS test ( CMPLRLLVM-69812 ). It is flaky and I have not been able to reproduce the error outside the context of the CTS environment.