[SYCL] Don't use zstd context across threads.
#19942
Merged
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ZSTDCompressor` holds `zstd` context as its only data members. The idea behind `GetSingletonInstance()` method was to re-use these contexts for subsequent compression and decompressions. Re-using context across (de)compression reduces system memory usage. However, `zstd` contexts are not meant to be used concurrently, therefore, this PR makes `ZSTDCompressor` object thread-local, instead of static. Relevant excerpt from zstd doc (https://facebook.github.io/zstd/zstd_manual.html): > When decompressing many times, > it is recommended to allocate a context only once, > and re-use it for each successive compression operation. > This will make workload friendlier for system's memory. > Use one context per thread for parallel execution.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 3, 2025
This is a known |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #19747
ZSTDCompressorholdszstdcontext as its only data members. The idea behindGetSingletonInstance()method was to re-use these contexts for subsequent compression and decompressions. Re-using context across (de)compression reduces system memory usage.However,
zstdcontexts are not meant to be used concurrently, therefore, this PR makesZSTDCompressorobject thread-local, instead of static.Relevant excerpt from zstd doc
(https://facebook.github.io/zstd/zstd_manual.html):