[NFC][SYCL][XPTI] Fix minor coverity hits #19952
Conversation
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| DeviceGlobalMap(const DeviceGlobalMap &) = default; | ||
| DeviceGlobalMap &operator=(const DeviceGlobalMap &) = default; |
| DeviceGlobalMap(const DeviceGlobalMap &) = default; | ||
| DeviceGlobalMap &operator=(const DeviceGlobalMap &) = default; | ||
|
|
||
| ~DeviceGlobalMap() noexcept(false) { |
There was a problem hiding this comment.
Coverity is complaining about C++ destructor implicitly marked as noexcept while the destructor body can throw an exception, in DeviceGlobalIt.second->cleanup();.
I've marked the destructor as noexcept(false) to indicate that destructor can throw
There was a problem hiding this comment.
I'm not sure this is a good solution. I tried it once and it just lead to more Coverity hits.
If this class is destroyed in any OTHER classes destructor, then the problem recurs. Do you mark that destructor as noexcept(false) too?
I guess many of our impl classes now have try/catch blocks and they stream out errors. But should that occur it'll likely be difficult to trace the problem back to here.
Anyway, I haven't thought about this deeply, and perhaps in this situation you have. Just wanted to check.
There was a problem hiding this comment.
I'm not sure this is a good solution. I tried it once and it just lead to more Coverity hits.
If this class is destroyed in any OTHER classes destructor, then the problem recurs. Do you mark that destructor as noexcept(false) too?
I see. If this solution leads to more Coverity hits, I'd be in favor of using try/catch instead, similar to what you did in #14273
There was a problem hiding this comment.
Fixed in 7627f88
| m_default_event_type = (uint16_t)xpti::trace_event_type_t::algorithm; | ||
| m_default_activity_type = xpti::trace_activity_type_t::active; | ||
| m_default_name = "Message"; // Likely never used | ||
| m_instID = 0; |
There was a problem hiding this comment.
Coverity was complaining about this field be left uninitialized in the constructor.
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This is a cherry-pick of #19952 Patch-by: Udit Kumar Agarwal <[email protected]>
No description provided.