Fix data race in the ProgramManager::getOrCreateDeviceKernelInfo #19966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| std::unordered_map<KernelNameStrT, DeviceKernelInfo> m_DeviceKernelInfoMap; | ||
|
|
||
| // Protects m_DeviceKernelInfoMap. | ||
| std::mutex m_DeviceKernelInfoMapMutex; |
There was a problem hiding this comment.
Do we need the guard here:
as well?
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
vinser52
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Sep 3, 2025
slawekptak
approved these changes
Sep 4, 2025
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data race was detected by a unit test while working on #19843.