[SYCL] Fix barrier on barrier dependency between queues #19970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Currently for the pattern like this:
sycl::event eb1 = q1.ext_oneapi_submit_barrier();
q2.ext_oneapi_submit_barrier({ eb1 });
the second barrier ignores eb1 in the waitlist because it is not marked
as enqueued even though it is supposed to. This PR fixes that.
Fixes intel#19777
againull
force-pushed
the
barrier_on_barrier
branch
from
2ae91f6 to
3f572e0
Compare
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Sep 4, 2025
|
@intel/llvm-gatekeepers please consider merging |
AlexeySachkov
pushed a commit
to AlexeySachkov/llvm
that referenced
this pull request
Sep 18, 2025
Currently for the pattern like this:
```
sycl::event eb1 = q1.ext_oneapi_submit_barrier();
q2.ext_oneapi_submit_barrier({ eb1 });
```
the second barrier ignores `eb1` in the waitlist because it is not
marked as enqueued even though it is supposed to. This PR fixes that.
Fixes intel#19777
AlexeySachkov
added a commit
that referenced
this pull request
Sep 18, 2025
This is a cherry-pick of #19970 Currently for the pattern like this: ``` sycl::event eb1 = q1.ext_oneapi_submit_barrier(); q2.ext_oneapi_submit_barrier({ eb1 }); ``` the second barrier ignores `eb1` in the waitlist because it is not marked as enqueued even though it is supposed to. This PR fixes that. Fixes #19777 Patch-by: Artur Gainullin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the pattern like this:
the second barrier ignores
eb1in the waitlist because it is not marked as enqueued even though it is supposed to. This PR fixes that.Fixes #19777