Skip to content

[SYCL] Fix a stale handler_impl reference with reductions #19975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

[SYCL] Fix a stale handler_impl reference with reductions #19975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sycl/source/detail/queue_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,6 @@ queue_impl::submit_impl(const detail::type_erased_cgfo_ty &CGF,
#else
handler Handler(shared_from_this(), SecondaryQueue, CallerNeedsEvent);
#endif
detail::handler_impl &HandlerImpl = *detail::getSyclObjImpl(Handler);

#ifdef XPTI_ENABLE_INSTRUMENTATION
if (xptiTraceEnabled()) {
Expand All @@ -326,6 +325,10 @@ queue_impl::submit_impl(const detail::type_erased_cgfo_ty &CGF,
CGF(Handler);
}

// We might swap handlers as part of the CGH(Handler) call in the reduction
// case, so need to retrieve the handler_impl reference after that.
detail::handler_impl &HandlerImpl = *detail::getSyclObjImpl(Handler);

// Scheduler will later omit events, that are not required to execute tasks.
// Host and interop tasks, however, are not submitted to low-level runtimes
// and require separate dependency management.
Expand Down
Loading