Skip to content

[UR][OpenCL] Delete unused copy constructors and assignments #19985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

[UR][OpenCL] Delete unused copy constructors and assignments #19985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92004b0
[UR][OpenCL] Delete unused copy constructors and assignments
kfelskow Sep 5, 2025
5a819d6
Fix formatting
kfelskow Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/context.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ struct ur_context_handle_t_ : ur::opencl::handle_base {
bool IsNativeHandleOwned = true;
ur::RefCount RefCount;

ur_context_handle_t_(const ur_context_handle_t_ &) = delete;
ur_context_handle_t_ &operator=(const ur_context_handle_t_ &) = delete;

ur_context_handle_t_(native_type Ctx, uint32_t DevCount,
const ur_device_handle_t *phDevices)
: handle_base(), CLContext(Ctx), DeviceCount(DevCount) {
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ struct ur_device_handle_t_ : ur::opencl::handle_base {
bool IsNativeHandleOwned = true;
ur::RefCount RefCount;

ur_device_handle_t_(const ur_device_handle_t_ &) = delete;
ur_device_handle_t_ &operator=(const ur_device_handle_t_ &) = delete;

ur_device_handle_t_(native_type Dev, ur_platform_handle_t Plat,
ur_device_handle_t Parent)
: handle_base(), CLDevice(Dev), Platform(Plat), ParentDevice(Parent) {
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/kernel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ struct ur_kernel_handle_t_ : ur::opencl::handle_base {
clSetKernelArgMemPointerINTEL_fn clSetKernelArgMemPointerINTEL = nullptr;
ur::RefCount RefCount;

ur_kernel_handle_t_(const ur_kernel_handle_t_ &) = delete;
ur_kernel_handle_t_ &operator=(const ur_kernel_handle_t_ &) = delete;

ur_kernel_handle_t_(native_type Kernel, ur_program_handle_t Program,
ur_context_handle_t Context)
: handle_base(), CLKernel(Kernel), Program(Program), Context(Context) {
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ struct ur_mem_handle_t_ : ur::opencl::handle_base {
bool IsNativeHandleOwned = true;
ur::RefCount RefCount;

ur_mem_handle_t_(const ur_mem_handle_t_ &) = delete;
ur_mem_handle_t_ &operator=(const ur_mem_handle_t_ &) = delete;

ur_mem_handle_t_(native_type Mem, ur_context_handle_t Ctx)
: handle_base(), CLMemory(Mem), Context(Ctx) {
urContextRetain(Context);
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/platform.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ struct ur_platform_handle_t_ : ur::opencl::handle_base {
std::map<cl_device_id, ur_device_handle_t> SubDevices;
std::mutex SubDevicesLock;

ur_platform_handle_t_(const ur_platform_handle_t_ &) = delete;
ur_platform_handle_t_ &operator=(const ur_platform_handle_t_ &) = delete;

ur_platform_handle_t_(native_type Plat) : handle_base(), CLPlatform(Plat) {}

~ur_platform_handle_t_() {
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ struct ur_queue_handle_t_ : ur::opencl::handle_base {
ur_event_handle_t LastEvent = nullptr;
ur::RefCount RefCount;

ur_queue_handle_t_(const ur_queue_handle_t_ &) = delete;
ur_queue_handle_t_ &operator=(const ur_queue_handle_t_ &) = delete;

ur_queue_handle_t_(native_type Queue, ur_context_handle_t Ctx,
ur_device_handle_t Dev, bool InOrder)
: handle_base(), CLQueue(Queue), Context(Ctx), Device(Dev),
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/opencl/sampler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ struct ur_sampler_handle_t_ : ur::opencl::handle_base {
bool IsNativeHandleOwned = false;
ur::RefCount RefCount;

ur_sampler_handle_t_(const ur_sampler_handle_t_ &) = delete;
ur_sampler_handle_t_ &operator=(const ur_sampler_handle_t_ &) = delete;

ur_sampler_handle_t_(native_type Sampler, ur_context_handle_t Ctx)
: handle_base(), CLSampler(Sampler), Context(Ctx) {
urContextRetain(Context);
Expand Down
Loading