[SYCL][Doc] Remove incorrect "KernelName" in spec #19992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overloads of `parallel_for` and `nd_launch` that take a `sycl::kernel` object should not allow the application to specify a name for the kernel. The kernel which is invoked by these overloads is determined at runtime (by the value of the `sycl::kernel` object), so it's not possible to assign a static name. The implementation was already correct, so this is just fixing a documentation bug.
|
@intel/llvm-gatekeepers please consider merging |
I agree. @intel/llvm-gatekeepers, I think this is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overloads of
parallel_forandnd_launchthat take asycl::kernelobject should not allow the application to specify a name for the kernel. The kernel which is invoked by these overloads is determined at runtime (by the value of thesycl::kernelobject), so it's not possible to assign a static name.The implementation was already correct, so this is just fixing a documentation bug.