-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL] Propagate data from handler to DeviceKernelInfo when using old binaries
#19993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
814d0ba to
068ae3a
Compare
068ae3a to
fab660c
Compare
fab660c to
0167154
Compare
0167154 to
ed117ec
Compare
ed117ec to
2222e7d
Compare
2222e7d to
37be97f
Compare
handler to DeviceKernelInfo when using old binaries
vinser52
approved these changes
Sep 8, 2025
steffenlarsen
approved these changes
Sep 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! It would be good with a quick summary of why it was needed and what was broken without it.
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeviceKernelInfoPtrwasn't/isn't used a single source of information neither before not after this PR, so things weren't "broken". However, we want to change that soon and for that we need all the necessary information fromhandler/handler_implto be available inDeviceKernelInfoPtr. That change brings us closer to that state.