Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Sep 5, 2025

DeviceKernelInfoPtr wasn't/isn't used a single source of information neither before not after this PR, so things weren't "broken". However, we want to change that soon and for that we need all the necessary information from handler/handler_impl to be available in DeviceKernelInfoPtr. That change brings us closer to that state.

@aelovikov-intel aelovikov-intel changed the title Test asserts [SYCL] Propagate data from handler to DeviceKernelInfo when using old binaries Sep 5, 2025
@aelovikov-intel aelovikov-intel marked this pull request as ready for review September 5, 2025 23:03
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner September 5, 2025 23:03
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It would be good with a quick summary of why it was needed and what was broken without it.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

@intel/llvm-gatekeepers please consider merging

@aelovikov-intel aelovikov-intel merged commit 613b865 into intel:sycl Sep 8, 2025
27 checks passed
@aelovikov-intel aelovikov-intel deleted the test-asserts branch September 8, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants