- 
                Notifications
    You must be signed in to change notification settings 
- Fork 794
[UR][OpenCL] Move banned platforms filtering to UR #20014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f262cbd    to
    467f2cf      
    Compare
  
    Filter out banned OpenCl platforms earlier, in the UR OpenCL adapter instead of the SYCL RT.
| Is there a reason this needs to be baked into the binary? Would having it be specified in a config file not mean it could be modified by vendors/sysadmins without having to rebuild DPCPP? | 
| } | ||
| } | ||
|  | ||
| static bool isBannedOpenCLPlatform(cl_platform_id platform) { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also ban opencl:fpga. If device name is not known for fpga, can we filter on the basis of device type? Perhaps by using clGetDeviceInfo (https://registry.khronos.org/OpenCL/specs/3.0-unified/html/OpenCL_API.html#platform-querying-devices)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ban opencl:fpga as well
| 
 This is to avoid possible future issues like this one by simplifying SYCL RT logic. This could possibly be made with a config file set with  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SYCL RT LGTM.
65dd137    to
    a0e693f      
    Compare
  
    | @intel/llvm-gatekeepers, please consider merging. Jenkins failure seems to be unrelated as it fails on other PRs, too. | 
Filter out banned OpenCl platforms earlier, in the UR OpenCL adapter instead of the SYCL RT.